New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New project fails to build #1037

Closed
ianrufus opened this Issue Feb 4, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@ianrufus
Copy link

ianrufus commented Feb 4, 2019

I'm submitting a bug report

  • Library Version:
    v1.0.0-beta.12

Please tell us about your environment:

  • Operating System:
    OSX 10.14

  • Node Version:
    10.15.1

  • NPM Version:
    6.4.1

  • Browser:
    all (build issue)

  • Language:
    ESNext

  • Loader/bundler:
    Webpack

Current behavior:
Installed Aurelia CLI, created blank project accepting all defaults - no modifications made myself following this
Running au build or au run --watch fails with errors:

ERROR in ./node_modules/@babel/polyfill/lib/index.js
Module not found: Error: Can't resolve 'core-js/fn/promise/finally' in '<my_dir>/aurelia-app/node_modules/@babel/polyfill/lib'
 @ ./node_modules/@babel/polyfill/lib/index.js 19:0-37
 @ ./src/main.js
 @ ./node_modules/aurelia-webpack-plugin/runtime/empty-entry.js
 @ multi aurelia-webpack-plugin/runtime/empty-entry aurelia-webpack-plugin/runtime/pal-loader-entry webpack-dev-server/client aurelia-webpack-plugin/runtime/empty-entry aurelia-webpack-plugin/runtime/pal-loader-entry aurelia-bootstrapper

ERROR in ./node_modules/@babel/polyfill/lib/index.js
Module not found: Error: Can't resolve 'core-js/fn/string/pad-end' in '<my_dir>/aurelia-app/node_modules/@babel/polyfill/lib'
 @ ./node_modules/@babel/polyfill/lib/index.js 9:0-36
 @ ./src/main.js
 @ ./node_modules/aurelia-webpack-plugin/runtime/empty-entry.js
 @ multi aurelia-webpack-plugin/runtime/empty-entry aurelia-webpack-plugin/runtime/pal-loader-entry webpack-dev-server/client aurelia-webpack-plugin/runtime/empty-entry aurelia-webpack-plugin/runtime/pal-loader-entry aurelia-bootstrapper

ERROR in ./node_modules/@babel/polyfill/lib/index.js
Module not found: Error: Can't resolve 'core-js/fn/string/pad-start' in '<my_dir>/aurelia-app/node_modules/@babel/polyfill/lib'
 @ ./node_modules/@babel/polyfill/lib/index.js 7:0-38
 @ ./src/main.js
 @ ./node_modules/aurelia-webpack-plugin/runtime/empty-entry.js
 @ multi aurelia-webpack-plugin/runtime/empty-entry aurelia-webpack-plugin/runtime/pal-loader-entry webpack-dev-server/client aurelia-webpack-plugin/runtime/empty-entry aurelia-webpack-plugin/runtime/pal-loader-entry aurelia-bootstrapper

ERROR in ./node_modules/@babel/polyfill/lib/index.js
Module not found: Error: Can't resolve 'core-js/fn/symbol/async-iterator' in '<my_dir>/aurelia-app/node_modules/@babel/polyfill/lib'
 @ ./node_modules/@babel/polyfill/lib/index.js 11:0-43
 @ ./src/main.js
 @ ./node_modules/aurelia-webpack-plugin/runtime/empty-entry.js
 @ multi aurelia-webpack-plugin/runtime/empty-entry aurelia-webpack-plugin/runtime/pal-loader-entry webpack-dev-server/client aurelia-webpack-plugin/runtime/empty-entry aurelia-webpack-plugin/runtime/pal-loader-entry aurelia-bootstrapper
Child html-webpack-plugin for "index.html":
         Asset      Size  Chunks  Chunk Names
    index.html  1.36 MiB       0
    Entrypoint undefined = index.html
    [8XHo] ./node_modules/html-webpack-plugin/lib/loader.js!./index.ejs 627 bytes {0} [built]
    [LvDl] ./node_modules/lodash/lodash.js 527 KiB {0} [built]
    [YuTi] (webpack)/buildin/module.js 497 bytes {0} [built]
    [yLpj] (webpack)/buildin/global.js 472 bytes {0} [built]
ℹ 「wdm」: Failed to compile.
  • What is the expected behavior?
    The project should build and run correctly
@huochunpeng

This comment has been minimized.

Copy link
Member

huochunpeng commented Feb 5, 2019

This is a combination of #970 and recently wrongly released aurelia-polyfills v1.3.2 which wrongly bring in jsom 0.16.53 to dependencies and that installed core-js v1.2.6 instead of core-s v2 at top level of node_modules.

In short, we will revert #970 and fix this issue.

@huochunpeng

This comment has been minimized.

Copy link
Member

huochunpeng commented Feb 5, 2019

For a local fix in the app, change webpack.config.js

from:

modules: [srcDir, nodeModulesDir],

back to

modules: [srcDir, 'node_modules'],

We are sorry for the regression caused.

@ianrufus

This comment has been minimized.

Copy link
Author

ianrufus commented Feb 5, 2019

Worked like a charm!
Thanks for looking at this so quickly 🙂

@ianrufus ianrufus closed this Feb 5, 2019

@huochunpeng

This comment has been minimized.

Copy link
Member

huochunpeng commented Feb 5, 2019

You don't have close this issue :-) We will close it in a commit.

@ianrufus

This comment has been minimized.

Copy link
Author

ianrufus commented Feb 5, 2019

No worries 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment