Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress task should fail in build when test(s) fail #1057

Closed
michaelw85 opened this Issue Feb 20, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@michaelw85
Copy link
Contributor

michaelw85 commented Feb 20, 2019

I'm submitting a bug report

  • Library Version:
    Local aurelia-cli v1.0.0-beta.12

Please tell us about your environment:

  • Operating System:
    Azure Pipelines Hosted VS2017 image (Windows Server 2016)

  • Node Version:
    10.14.2

  • NPM Version:
    6.5.0

  • Browser:
    N/A

  • Language:
    TS (lang independent)

  • Loader/bundler:
    Webpack (Bug probably occurs for any)

Current behavior:
When running au cypress --run with a failing test a build step does not fail.
Similar issue (different root cause): #1053

Root cause
Callback is not resolved. It should resolve without a message for success and with a error message on failure.

  • What is the expected behavior?
    If a test fails the task should fail.

  • What is the motivation / use case for changing the behavior?
    Azure build pipeline proceeds while tests are failing.

michaelw85 added a commit to michaelw85/cli that referenced this issue Feb 20, 2019

fix(cypress task): Return error when tests fail
Make au cypress --run emit error when a test failed to allow a build
process/step to fail.

Closes aurelia#1057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.