Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore missing in generated app? #1102

Closed
bsrdjan opened this issue May 17, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@bsrdjan
Copy link

commented May 17, 2019

Just generated all-defaults ESNext app, with aurelia-cli v1.0.0-beta.15 on node v10.15.3 and see there is no .gitignore in the new generated app root folder.

Is it a bug because the default .gitignore would be convenient?

@3cp

This comment has been minimized.

Copy link
Member

commented May 17, 2019

ls -al pls

@bsrdjan

This comment has been minimized.

Copy link
Author

commented May 17, 2019

Here it is. Missing also if skeleton-navigation app selected:

~/s/appq ❯❯❯ ls -la 
total 640
drwxr-xr-x   19 d037732  staff     608 May 17 22:00 .
drwxr-xr-x   65 d037732  staff    2080 May 17 21:52 ..
-rw-r--r--    1 d037732  staff     751 Oct 26  1985 .babelrc.js
-rw-r--r--    1 d037732  staff     257 Oct 26  1985 .editorconfig
-rw-r--r--    1 d037732  staff     147 Oct 26  1985 .eslintrc.json
drwxr-xr-x    5 d037732  staff     160 May 17 21:52 .vscode
-rw-r--r--    1 d037732  staff     594 Oct 26  1985 README.md
drwxr-xr-x    6 d037732  staff     192 May 17 21:52 aurelia_project
-rw-r--r--    1 d037732  staff   15086 Oct 26  1985 favicon.ico
-rw-r--r--    1 d037732  staff     390 Oct 26  1985 index.ejs
-rw-r--r--    1 d037732  staff     188 Oct 26  1985 jsconfig.json
drwxr-xr-x  936 d037732  staff   29952 May 17 21:53 node_modules
-rw-r--r--    1 d037732  staff    2779 Oct 26  1985 package.json
drwxr-xr-x    7 d037732  staff     224 May 17 21:52 src
drwxr-xr-x    3 d037732  staff      96 May 17 21:52 static
drwxr-xr-x    4 d037732  staff     128 May 17 21:52 test
-rw-r--r--    1 d037732  staff    7832 Oct 26  1985 webpack.config.js
drwxr-xr-x   16 d037732  staff     512 May 17 22:00 www
-rw-r--r--    1 d037732  staff  273951 May 17 21:53 yarn.lock
~/s/appq ❯❯❯
@3cp

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Thanks, I can reproduce the issue. Will fix soon.

3cp added a commit to 3cp/cli that referenced this issue May 18, 2019

fix(skeleton): fix missing .gitignore file in aurelia-cli npm package
When building npm package, `npm pack` ignored skeleton/common/.gitignore file because it by default ignores any .gitignore file. Rename .gitignore to .gitignore__append-if-exists is the cheapest way to bypass npm's default behaviour. The alternative fix is to use "files" field in package.json, but that's too verbose.

closes aurelia#1102

3cp added a commit to 3cp/cli that referenced this issue May 20, 2019

fix(skeleton): fix missing .gitignore file in aurelia-cli npm package
When building npm package, `npm pack` ignored skeleton/common/.gitignore file because it by default ignores any .gitignore file. Rename .gitignore to .gitignore__append-if-exists is the cheapest way to bypass npm's default behaviour. The alternative fix is to use "files" field in package.json, but that's too verbose.

closes aurelia#1102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.