Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode launch.json has incorrect extension for new projects using the cli bundler #1113

Closed
AquilaSands opened this issue Jun 7, 2019 · 1 comment · Fixed by #1115

Comments

@AquilaSands
Copy link

commented Jun 7, 2019

I'm submitting a bug report

  • Library Version:
    1.0.0

Please tell us about your environment:

  • Operating System:
    Windows10

  • Node Version:
    12.3.1

  • NPM Version:
    6.9.0
  • Browser:
    n/a

  • Language:
    all

  • Loader/bundler:
    RequireJS

Current behavior:
Creating a new app or plugin which uses the built in cli bundler and VSCode as the editor places the file launch.json_if_cli-bundler in the .vscode directory. This cause VSCode debugging to not find the config until it is renamed to launch.json

  • What is the expected behavior?
    The file has the correct extension .json

  • Steps to reproduce.

    • Use au new to scaffold a new app or plugin using the custom option
    • Ensure that the built in cli bundler and VSCode are selected
    • The resulting .vscode directory will have the incorrectly named launch.json
  • What is the motivation / use case for changing the behavior?
    Debugging in VSCode should just work

@3cp

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

My bad. Will fix the file name.

3cp added a commit to 3cp/cli that referenced this issue Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.