Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

au run --watch doesn't pick up changes from linked scss files #1138

Closed
arnederuwe opened this issue Jul 15, 2019 · 2 comments

Comments

@arnederuwe
Copy link
Contributor

commented Jul 15, 2019

I'm submitting a bug report

  • Library Version:
    1.0.2

Please tell us about your environment:

  • Operating System:
    Windows 10

  • Node Version:
    10.16.0

  • NPM Version:
    6.2.0
  • Browser:
    all

  • Language:
    TypeScript 3.5.1

  • Loader/bundler:
    RequireJS

Current behavior:
When you link multiple sass files with import statements, the changes of imported sass files aren't reflected in the app when the browser refreshes as a result of au run --watch, only the root required sass files's changes are reflected.
sasstest.zip

In the attached project, test.scss is directly required in app.html, any style change there is directly reflected in the app when running au run --watch, test.scss imports test-imported.scss, changes to that file are only reflected when you kill au run --watch and execute it again, greatly slowing down development

  • What is the expected behavior?

changes to imported sass files should also be reflected in the browser on refresh using au run --watch

@3cp

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

Sorry, I missed this, update your aurelia_project/tasks/process-css.ts, remove , since: gulp.lastRun(processCSS).

Because scss compilation is not one-to-one compilation, we cannot only send mutated files over watch mode, have to send all files to sass processor again.

Will fix this is next version.

@3cp 3cp self-assigned this Jul 15, 2019

@arnederuwe

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

Thank you for the quick reply and workaround!

@3cp 3cp closed this in 1d61223 Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.