Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webpack] cssRules does not apply to .scss files imported from a .html file. #1152

Closed
graycrow opened this issue Oct 31, 2019 · 2 comments · Fixed by #1153
Closed

[Webpack] cssRules does not apply to .scss files imported from a .html file. #1152

graycrow opened this issue Oct 31, 2019 · 2 comments · Fixed by #1153

Comments

@graycrow
Copy link
Contributor

@graycrow graycrow commented Oct 31, 2019

I'm submitting a bug report

  • Library Version:
    1.2.1

Please tell us about your environment:

  • Operating System:
    Windows 8.1

  • Node Version:
    13.0.1

  • NPM Version:
    6.12.1
  • Browser:
    all

  • Language:
    TypeScript 3.6.4

  • Loader/bundler:
    Webpack

Current behavior:
If I import SASS styles from the model (.ts), they are processed by the PostCss loader, autorefixer rules are applied, etc. If the same file is imported from the view (.html), the Css loader options are not applied.

probably should be replaced by something like this:
use: [...cssRules, ...sassRules],

  • What is the motivation / use case for changing the behavior?
    I'd like all styles to be handled equally. The appearance of the page should not depend on the import method.
@3cp

This comment has been minimized.

Copy link
Member

@3cp 3cp commented Oct 31, 2019

Sorry, I missed your point. Correct, it should be cssRules. PR welcome!

@3cp

This comment has been minimized.

Copy link
Member

@3cp 3cp commented Oct 31, 2019

@Sayan751 I thought we cleaned up css config. Can you review all of css config?

3cp added a commit that referenced this issue Oct 31, 2019
3cp added a commit that referenced this issue Oct 31, 2019
3cp added a commit that referenced this issue Oct 31, 2019
@3cp 3cp closed this in #1153 Nov 3, 2019
3cp added a commit that referenced this issue Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.