New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sourcemaps in karma #420

Closed
tlenczyk opened this Issue Nov 24, 2016 · 2 comments

Comments

Projects
None yet
3 participants
@tlenczyk

tlenczyk commented Nov 24, 2016

Hi,
When debugging my test code I don't see sourcemaps in chrome console (http://localhost:9876/debug.html)

After modifications in karma.conf.js sources appears

let sourceMapsApp = [{pattern: 'scripts/app-bundle.js.map', included: false}]; // I'm adding this map file 
let files = [entryBundle].concat(testSrc).concat(appSrc).concat(sourceMapsApp);

I don't know what I should change to attach also sourcemaps for test sources.
Do you have any ideas?

aurelia-cli 0.22.0

@EisenbergEffect

This comment has been minimized.

Show comment
Hide comment
@EisenbergEffect

EisenbergEffect Nov 24, 2016

Member

Interesting. We need to look into this. Please update us with any other findings or experiments that yield your expected output. We can use this to improve what our CLI generates.

Member

EisenbergEffect commented Nov 24, 2016

Interesting. We need to look into this. Please update us with any other findings or experiments that yield your expected output. We can use this to improve what our CLI generates.

@AStoker

This comment has been minimized.

Show comment
Hide comment
@AStoker

AStoker Nov 28, 2016

Member

We've included sourcemaps for our project the same way you have done. For test sources you need to tell babel that you want sourcemaps included, and make them inline, so that way you don't have to bring in external files (they're embedded in the transpiled file).

Member

AStoker commented Nov 28, 2016

We've included sourcemaps for our project the same way you have done. For test sources you need to tell babel that you want sourcemaps included, and make them inline, so that way you don't have to bring in external files (they're embedded in the transpiled file).

simonfox added a commit to simonfox/cli that referenced this issue Jun 16, 2017

feat(sourcemaps): inlcude sourcemaps in karma configuration
add the bundle source maps to karma files configuration and add inline source maps to transpiler options so unit tests also have source maps.

closes aurelia/cli#420

simonfox added a commit to simonfox/cli that referenced this issue Jun 16, 2017

feat(sourcemaps): inlcude sourcemaps in karma configuration
add the bundle source maps to karma files configuration and add inline source maps to transpiler options so unit tests also have source maps.

closes aurelia/cli#420

simonfox added a commit to simonfox/cli that referenced this issue Jul 6, 2017

feat(sourcemaps): inlcude sourcemaps in karma configuration
add the bundle source maps to karma files configuration and add inline source maps to transpiler options so unit tests also have source maps.

closes aurelia/cli#420

@JeroenVinke JeroenVinke closed this in #656 Jul 11, 2017

JeroenVinke added a commit that referenced this issue Jul 11, 2017

Merge pull request #656 from simonfox/feature/#420-unit-test-source-maps
feat(sourcemaps): inlcude sourcemaps in karma configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment