Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: enforce single aurelia-binding in webpack bundle #906
Conversation
This comment has been minimized.
This comment has been minimized.
|
@JeroenVinke This is another good PR to accompany the other I mentioned. This should help webpack users avoid multiple binding library bundles. |
JeroenVinke
merged commit d5135af
into
aurelia:master
Jul 26, 2018
huochunpeng
deleted the
huochunpeng:enforce-single-aurelia-binding-for-webpack
branch
Jul 26, 2018
added a commit
to huochunpeng/cli
that referenced
this pull request
Feb 4, 2019
added a commit
to huochunpeng/cli
that referenced
this pull request
Feb 4, 2019
huochunpeng
referenced this pull request
Feb 4, 2019
Merged
fix(jest): avoid aurelia-bindings v1+v2 conflict #1036
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
huochunpeng commentedJul 26, 2018
•
edited
aurelia/binding#702 this is to avoid v1/v2 duplication due to out-of-date dependencies on 3rd party aurelia plugins.