New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce single aurelia-binding in webpack bundle #906

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
3 participants
@huochunpeng
Copy link
Member

huochunpeng commented Jul 26, 2018

aurelia/binding#702 this is to avoid v1/v2 duplication due to out-of-date dependencies on 3rd party aurelia plugins.

fix: enforce single aurelia-binding in webpack bundle
This is to avoid v1/v2 duplication due to out-of-date dependencies on 3rd party aurelia plugins.
@EisenbergEffect

This comment has been minimized.

Copy link
Member

EisenbergEffect commented Jul 26, 2018

@JeroenVinke This is another good PR to accompany the other I mentioned. This should help webpack users avoid multiple binding library bundles.

@JeroenVinke JeroenVinke merged commit d5135af into aurelia:master Jul 26, 2018

2 checks passed

WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@huochunpeng huochunpeng deleted the huochunpeng:enforce-single-aurelia-binding-for-webpack branch Jul 26, 2018

huochunpeng added a commit to huochunpeng/cli that referenced this pull request Feb 4, 2019

huochunpeng added a commit to huochunpeng/cli that referenced this pull request Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment