New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack.config.template.js): webpack resolving child node_modules #970

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Projects
None yet
4 participants
@jbockle
Copy link
Contributor

jbockle commented Nov 14, 2018

Addressing #961, when a symlinked package (i.e. a lerna monorepo) exists in node_modules, the child node_modules are resolved in webpack, creating duplicate module ids like './node_modules/symlinked-package/node_modules/some-dependency/index.js' in addition to './node_modules/some-dependency/index.js'.

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Nov 14, 2018

CLA assistant check
All committers have signed the CLA.

@huochunpeng

This comment has been minimized.

Copy link
Member

huochunpeng commented Nov 19, 2018

LGTM
@EisenbergEffect can we get this in next release?

@EisenbergEffect EisenbergEffect merged commit 1e0c699 into aurelia:master Nov 19, 2018

2 checks passed

WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@huochunpeng

This comment has been minimized.

Copy link
Member

huochunpeng commented Feb 5, 2019

@EisenbergEffect we urgently have to revert this change from:

modules: [srcDir, nodeModulesDir],

back to

modules: [srcDir, 'node_modules'],

And reopen the closed #961.

We give up default webpack module resolutioin algorithm, and use only top level node_modules packages.

That creates wrong version of module being packed. #1037

@EisenbergEffect

This comment has been minimized.

Copy link
Member

EisenbergEffect commented Feb 5, 2019

@huochunpeng I've re-opened the issue. Ping me on the PR to revert and I can do a CLI release tonight.

huochunpeng added a commit to huochunpeng/cli that referenced this pull request Feb 5, 2019

EisenbergEffect added a commit that referenced this pull request Feb 5, 2019

Merge pull request #1038 from huochunpeng/revert-970
fix(webpack): revert #970 to restore default webpack module resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment