New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles still use old naming "ai-" instead of "ux-" #306

Closed
hoangcuongvn opened this Issue Jun 20, 2017 · 5 comments

Comments

Projects
None yet
6 participants
@hoangcuongvn

hoangcuongvn commented Jun 20, 2017

I'm submitting a bug report

  • Library Version:
    1.0.0-rc.1.0.3

  • Operating System:
    Windows 10

  • Node Version:
    6.2.0

  • NPM Version:
    3.8.9

  • JSPM OR Webpack AND Version
    webpack 2.6.1

  • Browser:
    all

  • Language:
    all

Current behavior:
Styles still use old naming "ai-" instead of "ux-".
https://github.com/aurelia/dialog/tree/master/styles

Expected/desired behavior:
Renaming "ai-" to "ux-" in input.less.

@StrahilKazlachev

This comment has been minimized.

Contributor

StrahilKazlachev commented Jun 21, 2017

@PWKad This file is not in use, the styles are inlined in dialog-configuration.ts/js since beta. Are there any plans to use it? If not I suggest we remove it.

@hoangcuongvn

This comment has been minimized.

hoangcuongvn commented Jun 21, 2017

I think it's used to generate that inline css. This input.less is necessary in customizing aurelia-dialog through custom css. So please do not remove it.

@StrahilKazlachev

This comment has been minimized.

Contributor

StrahilKazlachev commented Jun 21, 2017

@hoangcuongvn definitely not used. Currently they are out-of-sync. The inlined styles are OK, you can check if you want. There has not been any build task to do such injection.

@RichiCoder1

This comment has been minimized.

RichiCoder1 commented Jun 22, 2017

I'd like them to stick around as they make an excellent template if I want to replace the inline styles.

mttmccb added a commit to mttmccb/dialog that referenced this issue Jul 30, 2017

mttmccb added a commit to mttmccb/dialog that referenced this issue Feb 20, 2018

fix(css): update styles to use ux- prefix instead of ai-
ai- is no longer used, ux- is preferred prefix.

Closes aurelia#306
@Alexander-Taran

This comment has been minimized.

Member

Alexander-Taran commented Mar 13, 2018

pr seems legit
if css file is not used -> can merge
if css file is used and styles are wrong -> should be merged

StrahilKazlachev added a commit that referenced this issue Aug 11, 2018

fix(css): update styles to use ux- prefix instead of ai-
ai- is no longer used, ux- is preferred prefix.

Closes #306

StrahilKazlachev added a commit that referenced this issue Aug 11, 2018

fix(css): update styles to use ux- prefix instead of ai-
ai- is no longer used, ux- is preferred prefix.

Closes #306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment