Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogCloseError is not exposed in typings #382

Closed
silbinarywolf opened this issue Sep 13, 2019 · 2 comments · Fixed by #383
Closed

DialogCloseError is not exposed in typings #382

silbinarywolf opened this issue Sep 13, 2019 · 2 comments · Fixed by #383

Comments

@silbinarywolf
Copy link

@silbinarywolf silbinarywolf commented Sep 13, 2019

I'm submitting a bug report

  • Library Version:
    2.0.0-rc.7

Please tell us about your environment:

  • Language:
    TypeScript

Current behavior:
Cannot import DialogCloseResult, like so:

import { DialogCloseResult } from 'aurelia-dialog';

Looks like a mistake where the following file isn't importing the generated type info:

https://github.com/aurelia/dialog/blob/master/dist/types/aurelia-dialog.d.ts
https://github.com/aurelia/dialog/blob/master/dist/types/dialog-close-error.d.ts

Expected/desired behavior:
I should be able to import this type information.

@bigopon

This comment has been minimized.

Copy link
Member

@bigopon bigopon commented Sep 13, 2019

@silbinarywolf thanks for filing this. This is probably because of merging v2 to master work. Would be nice if you could help PR to fix this 👍

@StrahilKazlachev

This comment has been minimized.

Copy link
Contributor

@StrahilKazlachev StrahilKazlachev commented Sep 13, 2019

It only needs a reexport added to aurelia-dialog.ts.

StrahilKazlachev added a commit to StrahilKazlachev/dialog that referenced this issue Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.