New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): location of main definition file is incorrect (fixes #279) #280

Merged
merged 1 commit into from Apr 28, 2017

Conversation

Projects
None yet
3 participants
@AdamWillden
Contributor

AdamWillden commented Apr 28, 2017

Would this fix be sufficient to make this work again (#279)?

@AdamWillden AdamWillden changed the title from fix(typings): fix location of main definition file (fixes #279) to fix(typings): location of main definition file is incorrect (fixes #279) Apr 28, 2017

@StrahilKazlachev

This comment has been minimized.

Show comment
Hide comment
@StrahilKazlachev

StrahilKazlachev Apr 28, 2017

Contributor

Not familiar with typings, but I think it should. @unional can you chime in?
Also as I get it aurelia-framework should be added to the deps list, or not?

Contributor

StrahilKazlachev commented Apr 28, 2017

Not familiar with typings, but I think it should. @unional can you chime in?
Also as I get it aurelia-framework should be added to the deps list, or not?

@AdamWillden

This comment has been minimized.

Show comment
Hide comment
@AdamWillden

AdamWillden Apr 28, 2017

Contributor

I couldn't wait as we needed to do a release. I changed the aurelia-dialog entry in my typings file to github:aurelia/dialog/dist/amd/aurelia-dialog.d.ts thereby circumventing the incorrect typings entry in aurelia-dialog. This confirms to me that the change should work fine.

Contributor

AdamWillden commented Apr 28, 2017

I couldn't wait as we needed to do a release. I changed the aurelia-dialog entry in my typings file to github:aurelia/dialog/dist/amd/aurelia-dialog.d.ts thereby circumventing the incorrect typings entry in aurelia-dialog. This confirms to me that the change should work fine.

@StrahilKazlachev

This comment has been minimized.

Show comment
Hide comment
@StrahilKazlachev

StrahilKazlachev Apr 28, 2017

Contributor

@AdamWillden You've taken care of the breaking changes also, that's fast.

Contributor

StrahilKazlachev commented Apr 28, 2017

@AdamWillden You've taken care of the breaking changes also, that's fast.

@unional

This comment has been minimized.

Show comment
Hide comment
@unional

unional Apr 28, 2017

Contributor

Seems like the project does not create dist/aurelia-dialog.d.ts anymore so the path should be updated.

However I would update to the commonjs path to match what's in package.json

Also, nowadays you probably should be using typescript 2+ and you don't need typings for aurelia packages anymore.

Contributor

unional commented Apr 28, 2017

Seems like the project does not create dist/aurelia-dialog.d.ts anymore so the path should be updated.

However I would update to the commonjs path to match what's in package.json

Also, nowadays you probably should be using typescript 2+ and you don't need typings for aurelia packages anymore.

@AdamWillden

This comment has been minimized.

Show comment
Hide comment
@AdamWillden

AdamWillden Apr 28, 2017

Contributor

I have updated to use the commonjs path as per the suggestion by @unional. They should be identical in content. I've not tested it, however I'm quite sure I've not screwed up the file path!

@StrahilKazlachev the breaking changes for aurelia-dialog were very simple to accommodate 👍

@unional using JSPM I found I still needed to add typings... would be nice if I could do away with having to manage them.

Contributor

AdamWillden commented Apr 28, 2017

I have updated to use the commonjs path as per the suggestion by @unional. They should be identical in content. I've not tested it, however I'm quite sure I've not screwed up the file path!

@StrahilKazlachev the breaking changes for aurelia-dialog were very simple to accommodate 👍

@unional using JSPM I found I still needed to add typings... would be nice if I could do away with having to manage them.

@StrahilKazlachev StrahilKazlachev merged commit dcf51b9 into aurelia:master Apr 28, 2017

1 check passed

license/cla Contributor License Agreement is signed.
Details
@StrahilKazlachev

This comment has been minimized.

Show comment
Hide comment
@StrahilKazlachev

StrahilKazlachev Apr 28, 2017

Contributor

@AdamWillden Sorry to bother but could you sign our CLA.

Contributor

StrahilKazlachev commented Apr 28, 2017

@AdamWillden Sorry to bother but could you sign our CLA.

@unional

This comment has been minimized.

Show comment
Hide comment
@unional

unional Apr 28, 2017

Contributor

@AdamWillden yeah, that's why I added jspm support to typings.

Contributor

unional commented Apr 28, 2017

@AdamWillden yeah, that's why I added jspm support to typings.

@AdamWillden

This comment has been minimized.

Show comment
Hide comment
@AdamWillden

AdamWillden Apr 29, 2017

Contributor

@StrahilKazlachev I'm sure I already have, no?

Contributor

AdamWillden commented Apr 29, 2017

@StrahilKazlachev I'm sure I already have, no?

@StrahilKazlachev

This comment has been minimized.

Show comment
Hide comment
@StrahilKazlachev

StrahilKazlachev Apr 29, 2017

Contributor

@AdamWillden If so, sorry to bother. The CircleCI check seems to be on hiatus, a-a-a-and I went and merged without noticing.

Contributor

StrahilKazlachev commented Apr 29, 2017

@AdamWillden If so, sorry to bother. The CircleCI check seems to be on hiatus, a-a-a-and I went and merged without noticing.

@AdamWillden

This comment has been minimized.

Show comment
Hide comment
@AdamWillden

AdamWillden Apr 29, 2017

Contributor

@StrahilKazlachev no stress - I filled it out again to be sure :-)

Contributor

AdamWillden commented Apr 29, 2017

@StrahilKazlachev no stress - I filled it out again to be sure :-)

@AdamWillden AdamWillden deleted the AdamWillden:patch-1 branch Apr 29, 2017

StrahilKazlachev added a commit that referenced this pull request Jul 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment