Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct way of including polyfills #111

Merged
merged 1 commit into from
Jun 23, 2015
Merged

Conversation

lukeapage
Copy link
Contributor

Trying to follow the documentation, I found the example doesn't work... ?

  1. MutationObserver.js pulled in by the first script tag runs immediately and requires WeakMap, so that throws an exception
  2. after running jspm install github:polymer/mutationobservers I can reach the package with polymer/mutationobservers - just using mutationobservers fails.

I don't know if this is due to a later version of jspm, I'm not doing anything crazy, just following the setup of the skeleton project.

I guess if I am correct this will need changing in the other languages.

@EisenbergEffect
Copy link
Contributor

Hey Luke! Thanks for your contribution. Would you mind signing our CLA? https://docs.google.com/forms/d/1Npd68d32UDUKUYuCDDrW0VN5Lv8p-a6Ziaa2JFKp6Cg/viewform?c=0&w=1

@AshleyGrant I can't remember who tested this polyfill out originally. Was it you? If not, can you link that person in so we can investigate Luke's PR?

@lukeapage
Copy link
Contributor Author

Done

@EisenbergEffect
Copy link
Contributor

Thanks! One of our core team members who was working on IE9 support will investigate this shortly.

@AshleyGrant
Copy link
Contributor

@zewa666 and @martingust should take a look at this.

@zewa666
Copy link
Member

zewa666 commented Jun 11, 2015

Yeah it seems that from some updates ago JSPM installs github endpoints always as [authorname]/[projectname] instead as [projectname] inside the config.js map section. I've checked @lukeapage fix and it works 👍

@EisenbergEffect this ones ok to be merged

@lukeapage
Copy link
Contributor Author

And the script tag was a mistake?

@zewa666
Copy link
Member

zewa666 commented Jun 11, 2015

I guess so, tbh can't remember any more :) But I tried it now with IE9 without the script tag and it works

@EisenbergEffect
Copy link
Contributor

Thanks everyone! I will get this updated shortly.

@EisenbergEffect EisenbergEffect merged commit 6dedd97 into aurelia:master Jun 23, 2015
@EisenbergEffect
Copy link
Contributor

On a somewhat related note...I wonder if we could feature detect mutation observers in the bootstrapper and then dynamically load that polyfill. Thoughts?

@lukeapage
Copy link
Contributor Author

lukeapage commented Jun 23, 2015 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants