-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct way of including polyfills #111
Conversation
|
Hey Luke! Thanks for your contribution. Would you mind signing our CLA? https://docs.google.com/forms/d/1Npd68d32UDUKUYuCDDrW0VN5Lv8p-a6Ziaa2JFKp6Cg/viewform?c=0&w=1 @AshleyGrant I can't remember who tested this polyfill out originally. Was it you? If not, can you link that person in so we can investigate Luke's PR? |
|
Done |
|
Thanks! One of our core team members who was working on IE9 support will investigate this shortly. |
|
@zewa666 and @martingust should take a look at this. |
|
Yeah it seems that from some updates ago JSPM installs github endpoints always as [authorname]/[projectname] instead as [projectname] inside the config.js map section. I've checked @lukeapage fix and it works 👍 @EisenbergEffect this ones ok to be merged |
|
And the script tag was a mistake? |
|
I guess so, tbh can't remember any more :) But I tried it now with IE9 without the script tag and it works |
|
Thanks everyone! I will get this updated shortly. |
|
On a somewhat related note...I wonder if we could feature detect mutation observers in the bootstrapper and then dynamically load that polyfill. Thoughts? |
|
If the polyfill is bundled (which it would have to be for a production
build?), the cost to get into the polyfill is minimal and presumably the
first thing it does is feature detect..
So imo probably not worth it.
|
Trying to follow the documentation, I found the example doesn't work... ?
jspm install github:polymer/mutationobserversI can reach the package withpolymer/mutationobservers- just using mutationobservers fails.I don't know if this is due to a later version of jspm, I'm not doing anything crazy, just following the setup of the skeleton project.
I guess if I am correct this will need changing in the other languages.