Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript definitions: core-js #202

Closed
jods4 opened this issue Sep 7, 2015 · 14 comments
Closed

Typescript definitions: core-js #202

jods4 opened this issue Sep 7, 2015 · 14 comments

Comments

@jods4
Copy link
Contributor

@jods4 jods4 commented Sep 7, 2015

I am not sure in which repo to put this, but is it possible to strip out the
import * as core from 'core-js'
(sometimes just import 'core-js').
that is found in most .d.ts files distributed with Aurelia? It creates error because I don't have core-js definitions (I'm using lib.es6.d.ts).

Because it is not used directly, it makes no difference to remove it (but you probably need to have either lib.es6.d.ts or core-js to define some of the newer global stuff).

@EisenbergEffect
Copy link
Member

@EisenbergEffect EisenbergEffect commented Sep 7, 2015

That makes sense to me. @cmichaelgraham Can you comment on this?

@cmichaelgraham
Copy link
Contributor

@cmichaelgraham cmichaelgraham commented Sep 7, 2015

hmmmm... not sure about that. i think the import loads the polyfils. (even though it isn't referenced directly later in the code)

@EisenbergEffect
Copy link
Member

@EisenbergEffect EisenbergEffect commented Sep 7, 2015

I think he's referring directly to the d.ts files, not our source.

@jods4
Copy link
Contributor Author

@jods4 jods4 commented Sep 7, 2015

@cmichaelgraham This might be true from the sourcecode, but is irrelevant in the TS definitions.

@cmichaelgraham
Copy link
Contributor

@cmichaelgraham cmichaelgraham commented Sep 7, 2015

right - but the .d.ts files are generated from the source files

@EisenbergEffect
Copy link
Member

@EisenbergEffect EisenbergEffect commented Sep 7, 2015

Yes, but that import isn't needed for the d.ts right? So, I think he's asking if it could be removed as part of the d.ts generation.

@cmichaelgraham
Copy link
Contributor

@cmichaelgraham cmichaelgraham commented Sep 7, 2015

have the babel-dts-generator remove it? that should be possible. another regex that specifies the imports to remove?

@jods4
Copy link
Contributor Author

@jods4 jods4 commented Sep 7, 2015

Yes, I was asking to strip them from the .d.ts files if it's possible.

@EisenbergEffect
Copy link
Member

@EisenbergEffect EisenbergEffect commented Sep 7, 2015

@cmichaelgraham that sounds like it would work.

@cmichaelgraham
Copy link
Contributor

@cmichaelgraham cmichaelgraham commented Sep 7, 2015

roger that - i'll put it on the todo list 👍

@EisenbergEffect
Copy link
Member

@EisenbergEffect EisenbergEffect commented Sep 13, 2015

@cmichaelgraham Any progress on this?

@cmichaelgraham
Copy link
Contributor

@cmichaelgraham cmichaelgraham commented Sep 14, 2015

@EisenbergEffect no progress yet.

@EisenbergEffect
Copy link
Member

@EisenbergEffect EisenbergEffect commented Oct 24, 2015

@cmichaelgraham Have you had time to address this? It would be nice to fix up our d.ts files for the beta.

@jdanyow
Copy link
Member

@jdanyow jdanyow commented Mar 7, 2016

closing- aurelia no longer has a dependency on core-js

@jdanyow jdanyow closed this Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.