Typescript definitions: core-js #202

Closed
jods4 opened this Issue Sep 7, 2015 · 14 comments

Projects

None yet

4 participants

@jods4
Contributor
jods4 commented Sep 7, 2015

I am not sure in which repo to put this, but is it possible to strip out the
import * as core from 'core-js'
(sometimes just import 'core-js').
that is found in most .d.ts files distributed with Aurelia? It creates error because I don't have core-js definitions (I'm using lib.es6.d.ts).

Because it is not used directly, it makes no difference to remove it (but you probably need to have either lib.es6.d.ts or core-js to define some of the newer global stuff).

@EisenbergEffect
Member

That makes sense to me. @cmichaelgraham Can you comment on this?

@cmichaelgraham
Member

hmmmm... not sure about that. i think the import loads the polyfils. (even though it isn't referenced directly later in the code)

@EisenbergEffect
Member

I think he's referring directly to the d.ts files, not our source.

@jods4
Contributor
jods4 commented Sep 7, 2015

@cmichaelgraham This might be true from the sourcecode, but is irrelevant in the TS definitions.

@cmichaelgraham
Member

right - but the .d.ts files are generated from the source files

@EisenbergEffect
Member

Yes, but that import isn't needed for the d.ts right? So, I think he's asking if it could be removed as part of the d.ts generation.

@cmichaelgraham
Member

have the babel-dts-generator remove it? that should be possible. another regex that specifies the imports to remove?

@jods4
Contributor
jods4 commented Sep 7, 2015

Yes, I was asking to strip them from the .d.ts files if it's possible.

@EisenbergEffect
Member

@cmichaelgraham that sounds like it would work.

@cmichaelgraham
Member

roger that - i'll put it on the todo list 👍

@EisenbergEffect
Member

@cmichaelgraham Any progress on this?

@cmichaelgraham
Member

@EisenbergEffect no progress yet.

@mikeobrien mikeobrien referenced this issue in aurelia/bootstrapper Sep 27, 2015
Closed

TypeScript error in 0.17.0 #19

@EisenbergEffect
Member

@cmichaelgraham Have you had time to address this? It would be nice to fix up our d.ts files for the beta.

@jdanyow
Member
jdanyow commented Mar 7, 2016

closing- aurelia no longer has a dependency on core-js

@jdanyow jdanyow closed this Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment