New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript definitions: core-js #202

Closed
jods4 opened this Issue Sep 7, 2015 · 14 comments

Comments

Projects
None yet
4 participants
@jods4
Contributor

jods4 commented Sep 7, 2015

I am not sure in which repo to put this, but is it possible to strip out the
import * as core from 'core-js'
(sometimes just import 'core-js').
that is found in most .d.ts files distributed with Aurelia? It creates error because I don't have core-js definitions (I'm using lib.es6.d.ts).

Because it is not used directly, it makes no difference to remove it (but you probably need to have either lib.es6.d.ts or core-js to define some of the newer global stuff).

@EisenbergEffect

This comment has been minimized.

Show comment
Hide comment
@EisenbergEffect

EisenbergEffect Sep 7, 2015

Member

That makes sense to me. @cmichaelgraham Can you comment on this?

Member

EisenbergEffect commented Sep 7, 2015

That makes sense to me. @cmichaelgraham Can you comment on this?

@cmichaelgraham

This comment has been minimized.

Show comment
Hide comment
@cmichaelgraham

cmichaelgraham Sep 7, 2015

Member

hmmmm... not sure about that. i think the import loads the polyfils. (even though it isn't referenced directly later in the code)

Member

cmichaelgraham commented Sep 7, 2015

hmmmm... not sure about that. i think the import loads the polyfils. (even though it isn't referenced directly later in the code)

@EisenbergEffect

This comment has been minimized.

Show comment
Hide comment
@EisenbergEffect

EisenbergEffect Sep 7, 2015

Member

I think he's referring directly to the d.ts files, not our source.

Member

EisenbergEffect commented Sep 7, 2015

I think he's referring directly to the d.ts files, not our source.

@jods4

This comment has been minimized.

Show comment
Hide comment
@jods4

jods4 Sep 7, 2015

Contributor

@cmichaelgraham This might be true from the sourcecode, but is irrelevant in the TS definitions.

Contributor

jods4 commented Sep 7, 2015

@cmichaelgraham This might be true from the sourcecode, but is irrelevant in the TS definitions.

@cmichaelgraham

This comment has been minimized.

Show comment
Hide comment
@cmichaelgraham

cmichaelgraham Sep 7, 2015

Member

right - but the .d.ts files are generated from the source files

Member

cmichaelgraham commented Sep 7, 2015

right - but the .d.ts files are generated from the source files

@EisenbergEffect

This comment has been minimized.

Show comment
Hide comment
@EisenbergEffect

EisenbergEffect Sep 7, 2015

Member

Yes, but that import isn't needed for the d.ts right? So, I think he's asking if it could be removed as part of the d.ts generation.

Member

EisenbergEffect commented Sep 7, 2015

Yes, but that import isn't needed for the d.ts right? So, I think he's asking if it could be removed as part of the d.ts generation.

@cmichaelgraham

This comment has been minimized.

Show comment
Hide comment
@cmichaelgraham

cmichaelgraham Sep 7, 2015

Member

have the babel-dts-generator remove it? that should be possible. another regex that specifies the imports to remove?

Member

cmichaelgraham commented Sep 7, 2015

have the babel-dts-generator remove it? that should be possible. another regex that specifies the imports to remove?

@jods4

This comment has been minimized.

Show comment
Hide comment
@jods4

jods4 Sep 7, 2015

Contributor

Yes, I was asking to strip them from the .d.ts files if it's possible.

Contributor

jods4 commented Sep 7, 2015

Yes, I was asking to strip them from the .d.ts files if it's possible.

@EisenbergEffect

This comment has been minimized.

Show comment
Hide comment
@EisenbergEffect

EisenbergEffect Sep 7, 2015

Member

@cmichaelgraham that sounds like it would work.

Member

EisenbergEffect commented Sep 7, 2015

@cmichaelgraham that sounds like it would work.

@cmichaelgraham

This comment has been minimized.

Show comment
Hide comment
@cmichaelgraham

cmichaelgraham Sep 7, 2015

Member

roger that - i'll put it on the todo list 👍

Member

cmichaelgraham commented Sep 7, 2015

roger that - i'll put it on the todo list 👍

@EisenbergEffect

This comment has been minimized.

Show comment
Hide comment
@EisenbergEffect

EisenbergEffect Sep 13, 2015

Member

@cmichaelgraham Any progress on this?

Member

EisenbergEffect commented Sep 13, 2015

@cmichaelgraham Any progress on this?

@cmichaelgraham

This comment has been minimized.

Show comment
Hide comment
@cmichaelgraham

cmichaelgraham Sep 14, 2015

Member

@EisenbergEffect no progress yet.

Member

cmichaelgraham commented Sep 14, 2015

@EisenbergEffect no progress yet.

@EisenbergEffect

This comment has been minimized.

Show comment
Hide comment
@EisenbergEffect

EisenbergEffect Oct 24, 2015

Member

@cmichaelgraham Have you had time to address this? It would be nice to fix up our d.ts files for the beta.

Member

EisenbergEffect commented Oct 24, 2015

@cmichaelgraham Have you had time to address this? It would be nice to fix up our d.ts files for the beta.

@jdanyow

This comment has been minimized.

Show comment
Hide comment
@jdanyow

jdanyow Mar 7, 2016

Member

closing- aurelia no longer has a dependency on core-js

Member

jdanyow commented Mar 7, 2016

closing- aurelia no longer has a dependency on core-js

@jdanyow jdanyow closed this Mar 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment