Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(t-attribute): undefined and null bound values #314

Merged
merged 1 commit into from Feb 19, 2020

Conversation

@zewa666
Copy link
Member

zewa666 commented Feb 18, 2020

if the provided value is bound to a null or undefined property
the resulting value for translation should be an empty string

fixes issue #313

if the provided value is bound to a null or undefined property
the resulting value for translation should be an empty string

fixes issue #313
@zewa666

This comment has been minimized.

Copy link
Member Author

zewa666 commented Feb 18, 2020

@Sayan751 can you take a look at this PR? I've not found any issues when running the tests nor could think of anything that could be problematic with this change

@Sayan751

This comment has been minimized.

Copy link

Sayan751 commented Feb 18, 2020

@zewa666 looks good to me :)
I think this problem is not there in v2. May I ask you to add a test case there to check? I can do that later as well btw.

@zewa666 zewa666 mentioned this pull request Feb 19, 2020
@zewa666

This comment has been minimized.

Copy link
Member Author

zewa666 commented Feb 19, 2020

Thanks @Sayan751, I've created a draft PR over at the v2 repo. The same situation creates even more troubles there due to a failing string.split() call.

@zewa666 zewa666 merged commit 2a61ee7 into master Feb 19, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
build_and_test Workflow: build_and_test
Details
ci/circleci: test Your tests passed on CircleCI!
Details
coverage/coveralls First build on undefined-bound-value-for-attribute at 78.594%
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.