New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html-template-element): fix fatal error in IE11 when using webcomponents-lite #27

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
4 participants
@joncarlson
Contributor

joncarlson commented Dec 9, 2017

Fixes #9 and aurelia/loader#23
Code pulled from a closed PR #10 . PR was closed due to no response from original author.

Fixes a fatal error in IE11 when using the webcomponents-lite polyfill. The error is:

Unhandled rejection TypeError: Unable to get property 'querySelectorAll' of undefined or null reference.

fix(html-template-element): fix unable to get property querySelectorA…
…ll error when using webcomponents-lite in IE11
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Dec 9, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Dec 9, 2017

CLA assistant check
All committers have signed the CLA.

@CasiOo

This comment has been minimized.

Show comment
Hide comment
@CasiOo

CasiOo Dec 10, 2017

The existing test 'content' in document.createElement('template') returns false for me in IE11, which seems to be correct.
The same test for template support is used in the mdn docs here https://developer.mozilla.org/en-US/docs/Web/HTML/Element/template

I'm using IE 11.98.16299.0
Which IE11 versions don't support the existing test?

CasiOo commented Dec 10, 2017

The existing test 'content' in document.createElement('template') returns false for me in IE11, which seems to be correct.
The same test for template support is used in the mdn docs here https://developer.mozilla.org/en-US/docs/Web/HTML/Element/template

I'm using IE 11.98.16299.0
Which IE11 versions don't support the existing test?

@EisenbergEffect

This comment has been minimized.

Show comment
Hide comment
@EisenbergEffect

EisenbergEffect Dec 11, 2017

Member

@joncarlson Am I correct in understanding that the issue only results when the webcomponents polyfill is present and in IE?

Member

EisenbergEffect commented Dec 11, 2017

@joncarlson Am I correct in understanding that the issue only results when the webcomponents polyfill is present and in IE?

@joncarlson

This comment has been minimized.

Show comment
Hide comment
@joncarlson

joncarlson Dec 11, 2017

Contributor

@EisenbergEffect yes, thats correct. Specifically we're using Polymer components alongside Aurelia, requiring the webcomponents polyfill.

Contributor

joncarlson commented Dec 11, 2017

@EisenbergEffect yes, thats correct. Specifically we're using Polymer components alongside Aurelia, requiring the webcomponents polyfill.

@EisenbergEffect

This comment has been minimized.

Show comment
Hide comment
@EisenbergEffect

EisenbergEffect Dec 11, 2017

Member

@joncarlson Can you remove the dist folder commit please? I'll build that as part of the release process. If you can do that, I'll get this into the release this week.

Member

EisenbergEffect commented Dec 11, 2017

@joncarlson Can you remove the dist folder commit please? I'll build that as part of the release process. If you can do that, I'll get this into the release this week.

@joncarlson

This comment has been minimized.

Show comment
Hide comment
@joncarlson

joncarlson Dec 11, 2017

Contributor

@EisenbergEffect done, thanks Rob

Contributor

joncarlson commented Dec 11, 2017

@EisenbergEffect done, thanks Rob

@EisenbergEffect EisenbergEffect merged commit 9e4b62f into aurelia:master Dec 11, 2017

2 checks passed

WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment