From 224f5ace08b9359d1c035b42f1ae0a9e6f74652b Mon Sep 17 00:00:00 2001 From: Jedd Ahyoung Date: Fri, 12 Feb 2016 22:26:11 -0500 Subject: [PATCH] fix(router): log helpful error on missing viewport When a route does not configure all available viewports, the navigation plan will crash. Now, the navigation plan will log a helpful error with the missing viewport and the affected route. Fixes #241. --- src/navigation-plan.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/navigation-plan.js b/src/navigation-plan.js index 7cbba612..0939a98e 100644 --- a/src/navigation-plan.js +++ b/src/navigation-plan.js @@ -41,6 +41,9 @@ export function _buildNavigationPlan(instruction: NavigationInstruction, forceLi for (let viewPortName in prev.viewPortInstructions) { let prevViewPortInstruction = prev.viewPortInstructions[viewPortName]; let nextViewPortConfig = config.viewPorts[viewPortName]; + + if (!nextViewPortConfig) throw new Error(`Invalid Route Config: Configuration for viewPort "${viewPortName}" was not found for route: "${instruction.config.route}."`); + let viewPortPlan = plan[viewPortName] = { name: viewPortName, config: nextViewPortConfig,