New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong comment for bluebird script version #842

Closed
nasser-pro opened this Issue Jun 24, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@nasser-pro

nasser-pro commented Jun 24, 2017

I'm submitting a bug report

  • Aurelia Skeleton Version
    skeleton-esnext

Maybe the same issue exists in other skeletons. I didn't check.

  • Framework Version:
    1.1.2

Please tell us about your environment:

  • Operating System:
    Windows 10

  • Node Version:
    6.2.0

  • NPM Version:
    3.10.3

  • JSPM OR Webpack AND Version
    JSPM 0.16.32 | webpack 2.1.0-beta.17

  • Browser:
    all | Chrome XX | Firefox XX | Edge XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView

  • Language:
    ESNext

Current behavior:
The bluebird version number in comment is not right.

Expected/desired behavior:
Open the index.html file, the first line of comment on top of bluebird script tag says the version is locked at 4.6.3.
The version number is wrong and should be 3.4.1.

  • What is the expected behavior?
    Comment should say locked to version 3.4.1 instead of 4.6.3

  • What is the motivation / use case for changing the behavior?
    It's just a copy paste issue. Nothing important.

@EisenbergEffect

This comment has been minimized.

Show comment
Hide comment
@EisenbergEffect

EisenbergEffect Jun 27, 2017

Member

@AshleyGrant Can you investigate and PR any fixes needed for this?

Member

EisenbergEffect commented Jun 27, 2017

@AshleyGrant Can you investigate and PR any fixes needed for this?

AshleyGrant added a commit to AshleyGrant/skeleton-navigation that referenced this issue Jun 27, 2017

@AshleyGrant

This comment has been minimized.

Show comment
Hide comment
@AshleyGrant
Member

AshleyGrant commented Jun 27, 2017

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment