Permalink
Browse files

fix(if-core.js): child view re-binding issue

sets showing to false on unbind to ensure binding is carried out when view is re-shown
nested views were not re-bound when parent was re-shown

Resolves
#317
#315
  • Loading branch information...
discoaaron committed Oct 11, 2017
1 parent 85e1e8d commit 1c107ac4d92cfeb4c5614f70fbc3f88c87107730
View
@@ -33,6 +33,7 @@ define(["exports"], function (exports) {
this.view.unbind();
if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}
View
@@ -32,6 +32,7 @@ var IfCore = exports.IfCore = function () {
this.view.unbind();
if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}
View
@@ -23,6 +23,7 @@ export let IfCore = class IfCore {
this.view.unbind();
if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}
@@ -26,6 +26,7 @@ export var IfCore = function () {
this.view.unbind();
if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}
View
@@ -36,6 +36,7 @@ System.register([], function (_export, _context) {
this.view.unbind();
if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}
@@ -420,6 +420,7 @@ var IfCore = exports.IfCore = function () {
this.view.unbind();
if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}
View
@@ -31,6 +31,7 @@ export class IfCore {
// For example a view could be returned to the cache and reused while it's still
// attached to the DOM and animated.
if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}

0 comments on commit 1c107ac

Please sign in to comment.