Skip to content

Commit

Permalink
fix(if-core.js): child view re-binding issue
Browse files Browse the repository at this point in the history
sets showing to false on unbind to ensure binding is carried out when view is re-shown
nested views were not re-bound when parent was re-shown

Resolves
#317
#315
  • Loading branch information
discoaaron committed Oct 11, 2017
1 parent 85e1e8d commit 1c107ac
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions dist/amd/if-core.js
Expand Up @@ -33,6 +33,7 @@ define(["exports"], function (exports) {
this.view.unbind();

if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}

Expand Down
1 change: 1 addition & 0 deletions dist/commonjs/if-core.js
Expand Up @@ -32,6 +32,7 @@ var IfCore = exports.IfCore = function () {
this.view.unbind();

if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}

Expand Down
1 change: 1 addition & 0 deletions dist/es2015/if-core.js
Expand Up @@ -23,6 +23,7 @@ export let IfCore = class IfCore {
this.view.unbind();

if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}

Expand Down
1 change: 1 addition & 0 deletions dist/native-modules/if-core.js
Expand Up @@ -26,6 +26,7 @@ export var IfCore = function () {
this.view.unbind();

if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}

Expand Down
1 change: 1 addition & 0 deletions dist/system/if-core.js
Expand Up @@ -36,6 +36,7 @@ System.register([], function (_export, _context) {
this.view.unbind();

if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}

Expand Down
1 change: 1 addition & 0 deletions dist/temp/aurelia-templating-resources.js
Expand Up @@ -420,6 +420,7 @@ var IfCore = exports.IfCore = function () {
this.view.unbind();

if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}

Expand Down
1 change: 1 addition & 0 deletions src/if-core.js
Expand Up @@ -31,6 +31,7 @@ export class IfCore {
// For example a view could be returned to the cache and reused while it's still
// attached to the DOM and animated.
if (!this.viewFactory.isCaching) {
this.showing = false;
return;
}

Expand Down

0 comments on commit 1c107ac

Please sign in to comment.