Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signalBindingBehavior.bind has incorrect typings #338

Closed
tlawandi opened this Issue Jan 15, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@tlawandi
Copy link

tlawandi commented Jan 15, 2018

I'm submitting a bug report

  • Library Version:
    1.5.4

  • Operating System:
    10

  • Node Version:
    v6.11.2

  • Language
    TypeScript Version 2.5.1

Current behavior:
The Typings for SignalBindingBehavior.bind only takes 2 parameters.

Expected/desired behavior:

  • What is the expected behavior?
    Typing definitions should match the number of parameters the JavaScript code allows.

  • What is the motivation / use case for changing the behavior?
    I am using the signal binder to listen to culture changes on the application.

I am currently doing the following to get around the typing issue
const behavior: any = this._signalBindingBehavior;
behavior.bind(binding, source, "aurelia-translation-signal");

@Alexander-Taran

This comment has been minimized.

Copy link
Member

Alexander-Taran commented Mar 28, 2018

Would you like to provide a pull request for it @tlawandi ?
Seems like a reasonable enhancement.

drothmaler added a commit to nubix-de/templating-resources that referenced this issue Oct 11, 2018

Fix aurelia#338 (Improve Typings of SignalBindingBehavior.bind)
Name / Names parameter was missing in the SignalBindingBehavior typings.

drothmaler added a commit to nubix-de/templating-resources that referenced this issue Oct 11, 2018

fix: improve typescript typings of SignalBindingBehavior.bind
Name / Names parameter was missing in the SignalBindingBehavior typings.

Closes aurelia#338

drothmaler added a commit to nubix-de/templating-resources that referenced this issue Mar 21, 2019

fix: improve typescript typings of SignalBindingBehavior.bind
Name / Names parameter was missing in the SignalBindingBehavior typings.

Closes aurelia#338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.