Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<template repeat.for="" /> is not rendering in IE11 #22

Closed
bennage opened this issue Feb 18, 2015 · 15 comments · Fixed by #26
Closed

<template repeat.for="" /> is not rendering in IE11 #22

bennage opened this issue Feb 18, 2015 · 15 comments · Fixed by #26
Labels

Comments

@bennage
Copy link

bennage commented Feb 18, 2015

I have a view that looks like

<template repeat.for="item of collection">
  <!-- some stuff -->
</template>

Here's the actual template.

In Chrome (and Safari) this is render as expected, however it does not render correctly in IE11.
Instead, it renders the template once, even if the collection is empty.

Here's a live example, please compare this in Chrome with it in IE11.

@bennage
Copy link
Author

bennage commented Feb 23, 2015

@EisenbergEffect I'm willing to look into this problem, but I'd like know where to start. :-)

@EisenbergEffect
Copy link
Contributor

You might see if there's something going wrong in the html template element polyfill first. If there's nothing going wrong there, have a look inside the TemplateController class in the templating repo. There may be an issue there. Third place I would look is in the repeat implementation itself, in the templating-resources repo.

@EisenbergEffect
Copy link
Contributor

@bennage We've identified an issue with templates in IE11. Not sure if it's your issue yet, but we found one and have a fix. It's going out in the next release.

@bennage
Copy link
Author

bennage commented Feb 26, 2015

Groovy

-----Original Message-----
From: "Rob Eisenberg" notifications@github.com
Sent: ‎2/‎25/‎2015 6:03 PM
To: "aurelia/templating" templating@noreply.github.com
Cc: "Christopher Bennage" christopher@bennage.com
Subject: Re: [templating] is not rendering in IE11(#22)

@bennage We've identified an issue with templates in IE11. Not sure if it's your issue yet, but we found one and have a fix. It's going out in the next release.

Reply to this email directly or view it on GitHub.

@bennage
Copy link
Author

bennage commented Feb 27, 2015

When are you expecting the next release? I'm assuming this fix will be in 0.8.13?

@EisenbergEffect
Copy link
Contributor

The plan is to release today. I've got to do some repo maintenance first, then I'm going to do a fresh release of all libraries. After that, you should be able to run jspm update to get all the latest versions.

@bennage
Copy link
Author

bennage commented Mar 2, 2015

I updated to 0.8.14 for templating (and everything else to the latest), however I am still seeing the problem.
Here's the live example. (I just realized that I never pasted in the correct link above.)

@jdanyow
Copy link
Contributor

jdanyow commented Mar 2, 2015

In IE 11, using the live example app, when I click the "sample repository" link I hit this error:

error

@bennage
Copy link
Author

bennage commented Mar 2, 2015

Sorry, the "sample repository" link on the welcome page won't work because that is a private repo. (Though this does expose the need for better UX.)

Here's a direct link to a publicly accessible repo:
http://pundit.cloudapp.net/#/bennage/pundit/0e6d64473f7a53693ac3faea5d980fbadc0b185f/README.md

After you authenticated, it just redirected back to the home. Apologies for the confusion. Can you try the link above after you are signed in?

@jdanyow
Copy link
Contributor

jdanyow commented Mar 2, 2015

that worked- no errors at all this time. Is this the right result?
result

The show all / only markdown toggle works too

@bennage
Copy link
Author

bennage commented Mar 2, 2015

That is what I see in IE11 as well, however that is not the expected behavior. In Chrome and Safari, it renders as expected:
image

@jdanyow
Copy link
Contributor

jdanyow commented Mar 2, 2015

took another look- in terms of the network tab it looks like all your aurelia components are up to date except for the http-client. Probably unrelated.

Nothing really stood out- other than the DOM Explorer clearly showed things were kind of screwy. I wish I had a better answer for you but you might try dialing back the complexity of this view to the minimum necessary bindings/behaviors/templates necessary to reproduce the issue. Once you get to the point where you know "adding this behavior/binding/markup breaks this in IE" we'll probably be able to help you more.

Maybe someone else will have a better idea- in any case, let us know if you have something else you want us to take a look at- your app looks pretty cool by the way.

@sorenhoyer
Copy link

We're still facing this issue with ie11 and edge. repeat.for on the template tag doesn't refresh the page as the data changes, however when removing the template tag, it works :/

Edit: more specifically I'm talking about using templates within tables and just found this aurelia/html-template-element#3

@EisenbergEffect
Copy link
Contributor

@sorenhoyer Would the solution I describe in that issue work for you if we added template-start and template-end?

@sorenhoyer
Copy link

I guess, however I do prefer the "repeater on the tbody tag" solution which is proposed in that other thread - just didn't think it was valid html with multiple tbody tags within one table. It works just fine in ie, edge too though :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants