Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): pass through date input types, default config #286

Merged
merged 4 commits into from Jun 2, 2020

Conversation

MaximBalaganskiy
Copy link
Contributor

Returning true is needed to support clicks on a native calendar button.

Returning true is needed to support clicks on a native calendar button
@bigopon
Copy link
Member

bigopon commented Jun 2, 2020

I guess there's no reason to not pass this through. Though do we need to handle the value of date-* input differently? always get as Date object or just a string?

@MaximBalaganskiy
Copy link
Contributor Author

Converting to a date would be convenient but not consistent with the native input. Not sure, personally

@bigopon
Copy link
Member

bigopon commented Jun 2, 2020

Converting to a date would be convenient but not consistent with the native input. Not sure, personally

we have input.valueAsDate for this, though I've never tried all input/change events combination with different browsers to be sure enough of this either.

@MaximBalaganskiy MaximBalaganskiy changed the title fix(input): pass through date input types fix(input): pass through date input types, default config Jun 2, 2020
packages/input/src/ux-input.ts Outdated Show resolved Hide resolved
packages/input/src/ux-input.ts Outdated Show resolved Hide resolved
defineUxInputElementApis(element);
if (this.defaultConfiguration.theme !== undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ben-girardet we now have default configuration for the ux input as well

@bigopon bigopon merged commit 77de4d7 into aurelia:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants