Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smart-autocomplete path processing #117

Merged
merged 33 commits into from Mar 26, 2020
Merged

Fix smart-autocomplete path processing #117

merged 33 commits into from Mar 26, 2020

Conversation

@hiaux0
Copy link
Contributor

hiaux0 commented Feb 15, 2020

What was done

Issues arose stating, that the extension did not work for them.
Investigation revealed, that the path processing was the culprit.
This PR fixes that.

Testing

  • Run au new on a mac/linux/windows machine.
  • Create a custom-element (beside app.ts/html)
  • In the view type <custom-element
  • This should reveal

Ubuntu 18.04

image

Windows 10

vscode-auto-windows

Todo

  • Verify on a windows machine as well
  • #110 Custom Element and View Model variables in .html
  • #104 Go to Definition
    • ubuntu
    • windows
  • #109 in view autocomplete of viewModel vars
    • ubuntu
    • windows
@hiaux0

This comment has been minimized.

Copy link
Contributor Author

hiaux0 commented Feb 15, 2020

Re: CLA

Seems like I did not setup git correct on all my machines. Will look into that

@hiaux0 hiaux0 force-pushed the fix/autocomplete branch from d6a428a to 8b3a895 Feb 15, 2020
hiaux0 added 12 commits Feb 22, 2020
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Mar 7, 2020

CLA assistant check
All committers have signed the CLA.

@hiaux0 hiaux0 force-pushed the fix/autocomplete branch from 2295f2e to 7d4e23a Mar 7, 2020
hiaux0 added 3 commits Mar 8, 2020
This relates to ca3ac97
Reason: Only completion in the client resulted in Message: Unhandled method textDocument/completion
  Code: -32601
hiaux0 added 4 commits Mar 9, 2020
but to ubuntu (hopefully windows as well)
just having it on the client subscriber did not work (however need it for tests)
@hiaux0 hiaux0 force-pushed the fix/autocomplete branch from 6b3b193 to aa72929 Mar 15, 2020
@hiaux0 hiaux0 merged commit 334b66a into master Mar 26, 2020
5 checks passed
5 checks passed
WIP Ready for review
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
main Workflow: main
Details
@hiaux0 hiaux0 deleted the fix/autocomplete branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.