Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the syntax be changed (again) to match CSS Media Queries Level 4 #8

Closed
ausi opened this issue Jan 20, 2016 · 5 comments
Closed

Comments

@ausi
Copy link
Owner

ausi commented Jan 20, 2016

The Media Queries Level 4 draft allows a slightly different syntax for media features than cq-prolyfill. Using the same syntax as media queries would be more consistent and thus easier to reason about for CSS authors.

The current syntax would still be valid for simple queries e.g. width > 100px, but more variants would be possible like min-width: 100px, text-align: right or even 100px < width.

Queries with two comparisons would change from width > 100px < 200px to the range syntax of the specification 100px < width < 200px or 200px > width > 100px.

The color filters would be changed to a suffix so color lightness <= 20% gets color-lightness <= 20% or max-color-lightness: 20%.

The biggest difference is that media queries don’t allow the not-equal (!=) comparision, so :container(text-align != right) would become :not(:container(text-align = right)) or :not(:container(text-align: right)).

Are the benefits of this enough to justify another change to the syntax of cq-prolyfill? (+1 or -1 comments are welcome too :)

@maxhoffmann
Copy link

Using the same syntax as media queries would be more consistent and thus easier to reason about for CSS authors.

I agree the CQ syntax should be as close as possible to the MQ syntax. Even identical if possible in my opinion.

@MarcusJT
Copy link

+1 for following the MQ syntax

@tregusti
Copy link

tregusti commented Jul 2, 2016

So, not many responses here, but so far the consensus is to change the syntax. Any thoughts on going forward?

@ausi
Copy link
Owner Author

ausi commented Jul 3, 2016

I think you are right, we should change the syntax as suggested.

Any thoughts on going forward?

As soon as I’ve got time, I will work on it :)

@ausi ausi added this to To Do in Version 0.4.0 Jun 10, 2017
@ausi ausi moved this from To Do to Done in Version 0.4.0 Jun 10, 2017
@ausi
Copy link
Owner Author

ausi commented Jun 12, 2017

Implemented in version 0.4.0.

@ausi ausi closed this as completed Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants