Remove obsolete config properties #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
previously approved these changes
Jan 14, 2021
jimmyjames
force-pushed
the
remove-obsolete-config-properties
branch
from
b164360
to
438a951
Compare
lbalmaceda
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change removes the following networking client customization methods on
Auth0. From the migration guide:setWriteTimeoutInSeconds(seconds)andgetWriteTimeoutInSeconds(seconds)setTLS12Enforced()andisTLS12Enforced()The ability to configure the write timeout is being removed to simplify the networking client customization, and decouple from any specific client provider as much as possible. We will still support configuring the connect and read timeout settings.
TLS 1.2 is available on Android since API 16 but used by default since API 20. OkHttp v4 (the client this SDK uses internally) defaults to
MODERN_TLSwhich is described as only accepting TLS 1.2 and 1.3.Checklist
I have read the Auth0 general contribution guidelines
I have read the Auth0 Code of Conduct
All existing and new tests complete without errors