New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observable issue after upgrading to angular2 beta7 #39

Closed
slintes opened this Issue Feb 23, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@slintes
Contributor

slintes commented Feb 23, 2016

Hello,

after upgrading my angular2 project from beta2 to beta7 I have the following issue:
Type 'Observable<any>' is not assignable to type 'Observable<any>'. Property 'source' is protected but type 'Observable<T>' is not a class derived from 'Observable<T>'.
Reason is that this project depends on rxjs 5.0.0-beta.0, but angular moved to rxjs 5.0.0-beta.2, and the Observable changed.
PR follows...

Greetings, Marc

@slintes

This comment has been minimized.

Show comment
Hide comment
@slintes

slintes Feb 23, 2016

Contributor

see #40

Contributor

slintes commented Feb 23, 2016

see #40

@cschroeter

This comment has been minimized.

Show comment
Hide comment
@cschroeter

cschroeter Feb 23, 2016

Contributor

Hell yeah please :)

Contributor

cschroeter commented Feb 23, 2016

Hell yeah please :)

@slintes

This comment has been minimized.

Show comment
Hide comment
@slintes

slintes Feb 23, 2016

Contributor

I published my fix on npm temporarily. Fell free to use angular2-jwt-slintes 0.1.9 until this was merged (or fixed in another way), will delete my module afterwards.

Contributor

slintes commented Feb 23, 2016

I published my fix on npm temporarily. Fell free to use angular2-jwt-slintes 0.1.9 until this was merged (or fixed in another way), will delete my module afterwards.

@wmaurer

This comment has been minimized.

Show comment
Hide comment
@wmaurer

wmaurer Feb 26, 2016

Thanks @slintes, your temporary npm package solves my headaches.
I'm looking forward to an official fix from the auth0 team on this ...

EDIT:
Question: In angular2, rxjs and zone.js are peerDependencies. Shouldn't angular2-jwt work in a similar way, i.e. angular2, rxjs and zone.js be peerDependencies rather than dependencies?

wmaurer commented Feb 26, 2016

Thanks @slintes, your temporary npm package solves my headaches.
I'm looking forward to an official fix from the auth0 team on this ...

EDIT:
Question: In angular2, rxjs and zone.js are peerDependencies. Shouldn't angular2-jwt work in a similar way, i.e. angular2, rxjs and zone.js be peerDependencies rather than dependencies?

@chenkie chenkie closed this in 2032ae4 Feb 26, 2016

chenkie added a commit that referenced this issue Feb 26, 2016

Merge pull request #40 from slintes/angular2-beta7
fixes #39: Observable not assignable
@slintes

This comment has been minimized.

Show comment
Hide comment
@slintes

slintes Feb 29, 2016

Contributor

heads up, since my PR was merged I just unpublished my temporary module! :)

Contributor

slintes commented Feb 29, 2016

heads up, since my PR was merged I just unpublished my temporary module! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment