From 59a3431be0375810dca0a188e02baf7779370d0a Mon Sep 17 00:00:00 2001 From: Silvio Massari Date: Wed, 6 Jan 2016 12:19:28 -0300 Subject: [PATCH 1/2] listener were being removed before completion --- index.js | 6 ++++-- package.json | 3 ++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/index.js b/index.js index 943c89a..e35f393 100644 --- a/index.js +++ b/index.js @@ -159,7 +159,8 @@ KinesisStream.prototype._putRecords = function(requestContent) { } }); } - + }) + .on('complete', function() { req.removeAllListeners(); req.response.httpResponse.stream.removeAllListeners(); req.httpRequest.stream.removeAllListeners(); @@ -251,7 +252,8 @@ KinesisStream.prototype._write = function (chunk, encoding, done) { err.records = [ _.omit(record, 'StreamName') ]; } done(err); - + }) + .on('complete', function() { req.removeAllListeners(); req.response.httpResponse.stream.removeAllListeners(); req.httpRequest.stream.removeAllListeners(); diff --git a/package.json b/package.json index 1791afe..3ea8194 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,8 @@ }, "main": "index.js", "scripts": { - "test": "NODE_ENV=test istanbul cover _mocha -- -R spec --timeout 5000" + "test": "NODE_ENV=test mocha -R spec --timeout 5000", + "cover": "NODE_ENV=test istanbul cover _mocha -- -R spec --timeout 5000" }, "dependencies": { "aws-sdk": "~2.1.43", From 7f5c1d1fe64f0bc2f0e6f6c6c7214837df38d286 Mon Sep 17 00:00:00 2001 From: Silvio Massari Date: Wed, 6 Jan 2016 12:21:58 -0300 Subject: [PATCH 2/2] 1.4.8 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 3ea8194..7b1cb8a 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "aws-kinesis-writable", "description": "A bunyan stream for kinesis.", - "version": "1.4.7", + "version": "1.4.8", "author": "José F. Romaniello (http://joseoncode.com)", "repository": { "url": "git://github.com/auth0/kinesis-writable.git"