Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAUTH-277] prevent posting when captcha is required and empty #1774

Merged
merged 1 commit into from Dec 23, 2019

Conversation

@jfromaniello
Copy link
Member

@jfromaniello jfromaniello commented Dec 20, 2019

Changes

Do not post the login form when captcha is required but is empty.

References

  • Jira CAUTH-277

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@jfromaniello jfromaniello requested a review from auth0/dx-sdks-approver as a code owner Dec 20, 2019
@lbalmaceda lbalmaceda merged commit d6c9fd5 into auth0:master Dec 23, 2019
3 checks passed
3 checks passed
ci/circleci: build-and-test Your tests passed on CircleCI!
Details
license/snyk - package.json (auth0-sdks) No manifest changes detected
security/snyk - package.json (auth0-sdks) No manifest changes detected
@lbalmaceda
Copy link
Contributor

@lbalmaceda lbalmaceda commented Dec 23, 2019

Someone will take care of releasing this soon @jfromaniello. Please use yarn's GitHub source feature, for now, pointing to master branch.

@jfromaniello
Copy link
Member Author

@jfromaniello jfromaniello commented Dec 23, 2019

Thank you sir!

@lbalmaceda lbalmaceda added this to the v11.20.2 milestone Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants