Make placeholder text-only, add new placeholderHTML for additionalSignUpFields #1788
Conversation
placehlderhtml no verify... . Support for placeholderHTML
6c15e56
into
auth0:master
3 checks passed
3 checks passed
license/snyk - package.json (auth0-sdks)
No manifest changes detected
security/snyk - package.json (auth0-sdks)
No manifest changes detected
jfromaniello
added a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Mar 5, 2020
placehlderhtml no verify... . Support for placeholderHTML Co-authored-by: Steve Hobbs <steve.hobbs.mail@gmail.com>
davidpatrick
added a commit
to davidpatrick/lock
that referenced
this pull request
Jun 12, 2020
placehlderhtml no verify... . Support for placeholderHTML Co-authored-by: Steve Hobbs <steve.hobbs.mail@gmail.com>
jfromaniello
added a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
placehlderhtml no verify... . Support for placeholderHTML Co-authored-by: Steve Hobbs <steve.hobbs.mail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
additionalSignUpFields
placeholderproperty does not indicate it is HTML-capable for check boxes and could inadvertently be fed with externally-supplied values by an unsuspecting developer.This PR makes
placeholdertext-only and provides a newplaceholderHTMLwhich indicates it has HTML control and should not be supplied with unsanitized externally-supplied values.GHSA-w2pf-g6r8-pg22