From 2aae60e3239a511ba86489bf5bf3c83b3a8c24f9 Mon Sep 17 00:00:00 2001 From: Tushar Pandey Date: Mon, 22 Sep 2025 01:03:08 +0530 Subject: [PATCH] fix: do not import react in with-page-auth-required.ts --- src/server/helpers/with-page-auth-required.test.ts | 4 +++- src/server/helpers/with-page-auth-required.ts | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/server/helpers/with-page-auth-required.test.ts b/src/server/helpers/with-page-auth-required.test.ts index e9c7b342..ec1f7be3 100644 --- a/src/server/helpers/with-page-auth-required.test.ts +++ b/src/server/helpers/with-page-auth-required.test.ts @@ -139,7 +139,9 @@ describe("with-page-auth-required ssr", () => { Promise.resolve(React.createElement("div", {}, "foo")) ); const res = await handler({}); - expect(ReactDOMServer.renderToString(res)).toBe("
foo
"); + expect(ReactDOMServer.renderToString(res as React.ReactElement)).toBe( + "
foo
" + ); expect(auth0Client.getSession).toHaveBeenCalledTimes(1); }); diff --git a/src/server/helpers/with-page-auth-required.ts b/src/server/helpers/with-page-auth-required.ts index 41af2dfe..aff4647b 100644 --- a/src/server/helpers/with-page-auth-required.ts +++ b/src/server/helpers/with-page-auth-required.ts @@ -1,5 +1,4 @@ import type { ParsedUrlQuery } from "querystring"; -import type React from "react"; import { GetServerSideProps, GetServerSidePropsContext, @@ -44,10 +43,11 @@ export type AppRouterPageRouteOpts = { /** * An app route that has been augmented with {@link WithPageAuthRequired}. + * Returns unknown to avoid React dependency while maintaining type safety. */ export type AppRouterPageRoute = ( obj: AppRouterPageRouteOpts -) => Promise; +) => Promise; /** * If you have a custom returnTo url you should specify it in `returnTo`.