Supports HAPI 17 API #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/RequestValidator.js
Outdated
| } | ||
| catch (error){ | ||
| log('error', 'Unable to compile and validate schemas', error); | ||
| return reply(error); | ||
| return error; |
There was a problem hiding this comment.
Don't know if it's possible to return a boom error on hapi 17, but maybe it's better to throw it? It's a bit confusing to return error imo.
lib/RequestValidator.js
Outdated
| @@ -48,14 +45,14 @@ var RequestValidator = function(plugin, options) { | |||
| report = routeSchemaManager['validate' + capitalizedParts](request); | |||
|
|
|||
| if (!report.valid){ | |||
| return reply(Boom.badRequest(configuredErrorReporters[parts[i]].extractMessage({ report: report, context: { request: request } }))); | |||
| return Boom.badRequest(configuredErrorReporters[parts[i]].extractMessage({ report: report, context: { request: request } })); | |||
lib/RequestValidator.js
Outdated
| } | ||
| return reply(Boom.internal(errorMessages)); | ||
| return Boom.internal(errorMessages); |
lib/ratify.js
Outdated
| } | ||
| else { | ||
| reply(Boom.notFound()); | ||
| return Boom.notFound(); |
dafortune
reviewed
Feb 8, 2018
| @@ -6,7 +6,7 @@ var ZSchema = require('z-schema'), | |||
| var RouteSchemaManager = function(options) { | |||
| options = options || {}; | |||
|
|
|||
| var schemasByServerUri = {}, | |||
| var schemasByKey = {}, | |||
There was a problem hiding this comment.
This is because hapi does not support multiple connections anymore, right?
dafortune
reviewed
Feb 8, 2018
| }; | ||
| }); | ||
| var get = function (request, h) { | ||
| return { clientId: 'fnord', email: 'myemail@fake.com' }; |
|
We don't want to handle all the problems at the same time so 👍 on doing the minimal changes, although |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HAPI version 17 does not support the concept of connection hapijs/hapi#3658 because of this what
server.table()returns changedBecause of this is the major change, and the flattening of
schemasByKey, previousschemasByServerUri. Could ve possible replace this idea withvhostand use it to create the key.Since the HAPI new API, introduces breaking changes this update does not escape that therefore, this is a mayor version update.