Skip to content

Conversation

@agwego
Copy link
Contributor

@agwego agwego commented Jan 7, 2018

This is a substantial change:

  • removed the dependency on org.json and replaced with gson in driverutils.
  • Added the ability to submit custom type adaptors (serializers/deserializers)
  • MetaData can now be an arbitrary object
  • Asset.Data can now be an arbitrary object
  • jsonutils no longer caches gson object, it maybe worth revisiting this in the future, but with custom type adaptors it makes more sense to build the gson object dynamically, removed json pretty printing
  • json utils no longer formats json strings al
  • added AssetSerializer
  • added Transaction.toHashInput to create the json string for hashing this now uses TransactionIdExclusionStrategy to remove the transaction ID.

Some assorted cleanup.

agwego and others added 3 commits November 30, 2017 08:35
Merge from Origin - 2017-11-30
generic Asset.data object instead of Map<String,String>
generic MetaData object instead of Map<String,String>
Custom TypeAdapters can be added for custom serializers and deserializers.
AssetSerializer to work with arbitrary Asset.data objects
Removed library json.org and replaced with GSON.
TransactionIdExclusionStrategy the gson way of excluding parameters on demand
transaction now has toHashInput() to generate the json string for hashing.

Removed json prettyprinting

Assorted cleanup
@agwego
Copy link
Contributor Author

agwego commented Jan 12, 2018

Can someone please fix Travis CI, the java-crypto-conditions:jar:2.0.0-SNAPSHOT aren't being handled properly (loaded into maven's dependency cache)
See pom.xml
mvn install:install-file -Dfile=<absolute_path_to_repo>\libs\java-crypto-conditions-2.0.0-SNAPSHOT.jar -DgroupId=org.interledger -DartifactId=java-crypto-conditions -Dversion=2.0.0-SNAPSHOT -Dpackaging=jar

@agwego
Copy link
Contributor Author

agwego commented Jan 12, 2018

OK I resolved the java-crypto-conditions issue with Travis-CI

@alvin-reyes alvin-reyes merged commit 3eff471 into authenteq-zz:master Jan 31, 2018
@alvin-reyes
Copy link
Collaborator

Looks great. I've been thinking of creating a separate crypto conditions library so that we're not too dependent on authenteq version

@agwego
Copy link
Contributor Author

agwego commented Feb 1, 2018

With respect to the crypto-conditions we should see if we can transition to the official one from Hyperledger - https://github.com/hyperledger/quilt/tree/master/crypto-conditions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants