Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update api for wildcard support #42

Merged
merged 2 commits into from Dec 9, 2021

Conversation

josephschorr
Copy link
Member

@josephschorr josephschorr commented Dec 9, 2021

@josephschorr josephschorr requested a review from jzelinskie Dec 9, 2021
@@ -0,0 +1,102 @@
// The contents of this file are hand-written to add AdditionalValidation to select message types
Copy link
Member

@jzelinskie jzelinskie Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't name this pb.go -- that's explicitly used as the naming convention for marking files as generated

Copy link
Member Author

@josephschorr josephschorr Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we use it for the other non-generated files, but I can drop it if you like

@jzelinskie jzelinskie merged commit 6dfdd04 into authzed:main Dec 9, 2021
4 checks passed
@josephschorr josephschorr deleted the update-api-wildcard branch Dec 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants