-
Notifications
You must be signed in to change notification settings - Fork 36
docs: fixed workflow #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fixed workflow #466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment - otherwise it's looking good to me.
.github/workflows/docs.yaml
Outdated
| gh pr create \ | ||
| --body "" \ | ||
| --title "docs: update zed docs" \ | ||
| --head "update-generated-docs" \ | ||
| --base "main" | ||
| else | ||
| echo "No changes detected in $TARGET_DOCS_FILE." | ||
| echo "CHANGES_DETECTED=false" >> $GITHUB_ENV | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you seen this action? https://github.com/marketplace/actions/create-pull-request
Would it work for this use case? We use it in other actions: https://github.com/authzed/authzed-node/blob/main/.github/workflows/automatic-api-update.yaml#L37-L47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah did have a look over the documentation, kartikaysaxena/docs#2 was the result of changes, switching to this action.
d403ce1 to
78bb72b
Compare
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
78bb72b to
e21dd45
Compare
tstirrat15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this looks good!
|
There was a perms failure: https://github.com/authzed/zed/actions/runs/13243163183/job/36963066495 I think there might be something about a PAT or the permissions on the token declared at the top of the file? I'm curious as to why it worked in your fork but not here. |
Related #464
Fixed workflow, tested on fork, example PR kartikaysaxena/docs#1
The token should have read/write permissions