Skip to content

Conversation

@kartikaysaxena
Copy link
Contributor

Fixes #471

This adds support for a socks5 proxy via a new flag

kartikaysaxena and others added 3 commits March 3, 2025 01:04
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
@tstirrat15
Copy link
Contributor

@kartikaysaxena the changes look good to me, but I'm not that familiar with this part of the gRPC client. Were you able to test this locally and see that it works?

@kartikaysaxena
Copy link
Contributor Author

@kartikaysaxena the changes look good to me, but I'm not that familiar with this part of the gRPC client. Were you able to test this locally and see that it works?

yeah tried with local socks5 proxy server using github.com/armon/go-socks5 and then ./zed schema write root.zed --proxy=socks5://127.0.0.1:8000 --insecure and it forwards that request to spicedb endpoint

kartikaysaxena and others added 2 commits March 4, 2025 02:19
Signed-off-by: Kartikay <kartikay_2101ce32@iitp.ac.in>
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@tstirrat15 tstirrat15 merged commit 2435d78 into authzed:main Mar 3, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2025
@kartikaysaxena kartikaysaxena deleted the proxy/socks5 branch March 3, 2025 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support connecting via SOCKS5 proxy

2 participants