add client-wide retries #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
reviewed
Apr 24, 2025
Comment on lines
+40
to
+43
| defaultRetryExponentialBackoff = 100 * time.Millisecond | ||
| defaultMaxRetryAttemptDuration = 2 * time.Second | ||
| defaultRetryJitterFraction = 0.5 | ||
| ) |
Contributor
There was a problem hiding this comment.
If the upstream is just straight-up unavailable (say you fatfingered your port), will 20 retries + this configuration mean that zed appears to hang for a long time? Should we have a smaller number of retries by default?
Contributor
Author
There was a problem hiding this comment.
You can terminate the command manually in that case, but I'm ok changing the default number of retries. What do you think would be a sensible value? I've dialed it down to 10
Contributor
There was a problem hiding this comment.
We chatted on this and 10 retries seems like a sane number.
Introduces gRPC middleware to do client-side retries by default. The only flag introduced to customize this behaviour is the maximum number of attempts, which defaults to 20. The retries are enabled for bot unary and streaming APIs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces gRPC middleware to do client-side retries by default. The only flag introduced to customize this behaviour is the maximum number of attempts, which defaults to 20.
Retries are enabled for both unary and streaming bot APIs.
retries_and_resume_demo.mp4