-
Notifications
You must be signed in to change notification settings - Fork 36
auto-generate more complete docs #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b4209c1 to
564eae3
Compare
| dist/ | ||
| temp/ | ||
| docs/ | ||
| docs/merged.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love this tbh 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring this specific file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
9ac6c37 to
201a216
Compare
492006a to
1bf693b
Compare
tstirrat15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as is; we can modify further if needed.
| dist/ | ||
| temp/ | ||
| docs/ | ||
| docs/merged.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring this specific file?
| DOCS_BRANCH: "main" | ||
| GENERATED_DOCS_FILE: "docs/zed.md" | ||
| TARGET_DOCS_FILE: "pages/zed/zed.md" | ||
| TARGET_DOCS_FILE: "pages/spicedb/getting-started/installing-zed.mdx" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me wonder if we should reorganize this page on the docs side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, maybe...
Description
This PR attempts to make the public-facing docs (https://authzed.com/docs/spicedb/getting-started/installing-zed) more complete by including both installation docs and a reference to all the commands.
The idea:
docs/now contains 2 filesgetting-startedis what exists today in https://authzed.com/docs/spicedb/getting-started/installing-zed and what exists in today's README (I don't love the duplication 😢 )zed.mdis auto-generated viamage gen:docsThen on every PR, we run
mage gen:docsForPublishwhich generatesdocs/merged.mdand pushes it to the docs repo.Testing
Run
mage gen:docsForPublishand look atdocs/merged.md😄