Skip to content

Conversation

@miparnisari
Copy link
Contributor

@miparnisari miparnisari commented Apr 28, 2025

Description

This PR attempts to make the public-facing docs (https://authzed.com/docs/spicedb/getting-started/installing-zed) more complete by including both installation docs and a reference to all the commands.

The idea:

Then on every PR, we run mage gen:docsForPublish which generates docs/merged.md and pushes it to the docs repo.

Testing

Run mage gen:docsForPublish and look at docs/merged.md 😄

@miparnisari miparnisari changed the title auto-generate docs auto-generate more complete docs Apr 28, 2025
@miparnisari miparnisari force-pushed the amend-docs branch 2 times, most recently from b4209c1 to 564eae3 Compare April 28, 2025 19:47
dist/
temp/
docs/
docs/merged.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love this tbh 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring this specific file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@miparnisari miparnisari force-pushed the amend-docs branch 3 times, most recently from 9ac6c37 to 201a216 Compare April 28, 2025 19:59
@miparnisari miparnisari marked this pull request as ready for review April 28, 2025 20:10
@miparnisari miparnisari force-pushed the amend-docs branch 4 times, most recently from 492006a to 1bf693b Compare April 30, 2025 23:34
@miparnisari miparnisari requested a review from tstirrat15 April 30, 2025 23:34
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as is; we can modify further if needed.

dist/
temp/
docs/
docs/merged.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring this specific file?

DOCS_BRANCH: "main"
GENERATED_DOCS_FILE: "docs/zed.md"
TARGET_DOCS_FILE: "pages/zed/zed.md"
TARGET_DOCS_FILE: "pages/spicedb/getting-started/installing-zed.mdx"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me wonder if we should reorganize this page on the docs side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, maybe...

@miparnisari miparnisari enabled auto-merge May 2, 2025 01:02
@miparnisari miparnisari merged commit b1aa8d9 into main May 2, 2025
10 checks passed
@miparnisari miparnisari deleted the amend-docs branch May 2, 2025 01:06
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants