Fix regression in warning output #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
force-pushed
the
537-fix-warning-output
branch
3 times, most recently
from
3442efc to
c2cb26c
Compare
tstirrat15
force-pushed
the
537-fix-warning-output
branch
from
c2cb26c to
89742e0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #537. zed points at the wrong line when validating the attached schema.
This is a partial fix for the issue; this issue will still manifest in composable schemas. Fixing that problem will require a more substantial rework of composable schema compilation, so we're deferring it for now.
Changes
Testing
Review. See that tests pass.