Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added interval input to specify polling interval #37

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

Yarimizu14
Copy link
Contributor

@Yarimizu14 Yarimizu14 commented Oct 4, 2023

added interval argument to specify polling interval to fetch test results.

@Yarimizu14 Yarimizu14 requested a review from a team October 4, 2023 07:21
@Yarimizu14 Yarimizu14 marked this pull request as ready for review October 4, 2023 07:42
@4ydx
Copy link

4ydx commented Oct 5, 2023

In the autify-cli should we perhaps make sure that the value they entered is, at minimum, 1 second? It should be added in the autify-cli itself HERE.

@4ydx
Copy link

4ydx commented Oct 5, 2023

To be honest, it is more friendly to the end user to cache the previous response and check if it has changed or not. In other words only display when a change occurs. But if that seems too much I am ok with this PR.

@Yarimizu14
Copy link
Contributor Author

@4ydx

In the autify-cli should we perhaps make sure that the value they entered is, at minimum, 1 second?

Sounds good. Let me add the validation to the CLI.

To be honest, it is more friendly to the end user to cache the previous response and check if it has changed or not. In other words only display when a change occurs.

I considered that. But I thought that adding an option to change the interval is good to start with and we can work on display for a status change with another PR.

@Yarimizu14 Yarimizu14 merged commit a467d58 into main Oct 5, 2023
7 checks passed
@Yarimizu14 Yarimizu14 deleted the feat/add-polling-interval-input branch October 5, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants