Add possibility install 'auto-complete' with popup & fuzzy provided by system #221

Open
vp1981 opened this Issue Mar 25, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@vp1981

vp1981 commented Mar 25, 2013

Hello,
I package (for myself) auto-complete on Archlinux x86_64 using standard package manager 'pacman'. Current 'Makefile' very restrictive wrt location of 'popup' and 'fuzzy' 'packages'.

I prepared patch for 'Makefile' and tested it with bare 'auto-complete', with 'auto-complete' with cloned submodules and bare 'auto-complete' with installed system packages 'popup' and 'fuzzy'.

Here the patch:
https://gist.github.com/vp1981/5234708

@tkf

This comment has been minimized.

Show comment Hide comment
@tkf

tkf Mar 25, 2013

Member

We are not encouraging people to use git submodule for installing. It is only for testing. If you are packaging AC and its dependencies, please package them separately and add appropriate dependency information.

Member

tkf commented Mar 25, 2013

We are not encouraging people to use git submodule for installing. It is only for testing. If you are packaging AC and its dependencies, please package them separately and add appropriate dependency information.

@vp1981

This comment has been minimized.

Show comment Hide comment
@vp1981

vp1981 Mar 26, 2013

Hi,
yes I do exactly that: I have two separate packages for 'popup' and for 'fuzzy' while AC depends on both. But to package AC I use 'Makefile', namely

make byte-compile

and after that

make DIR=${pkgdir}/usr/share/emacs/site-lisp install

Of course first 'make' command fails due to explicit reference to 'lib/popup' and 'lib/fuzzy'.

My patch resolves this issue: when I need to 'byte-compile' I run

make SITE_LISP="/usr/share/emacs/site-lisp" byte-compile

and then next

make SITE_LISP="/usr/share/emacs/site-lisp" DIR=${pkgdir}/usr/share/emacs/site-lisp install

On the other hand, I can just insert commands that 'byte-compile' and 'install' targets run into PKGBUILD (file used by package building tool of my system) but use of 'Makefile' to install all needed files is common practice.

vp1981 commented Mar 26, 2013

Hi,
yes I do exactly that: I have two separate packages for 'popup' and for 'fuzzy' while AC depends on both. But to package AC I use 'Makefile', namely

make byte-compile

and after that

make DIR=${pkgdir}/usr/share/emacs/site-lisp install

Of course first 'make' command fails due to explicit reference to 'lib/popup' and 'lib/fuzzy'.

My patch resolves this issue: when I need to 'byte-compile' I run

make SITE_LISP="/usr/share/emacs/site-lisp" byte-compile

and then next

make SITE_LISP="/usr/share/emacs/site-lisp" DIR=${pkgdir}/usr/share/emacs/site-lisp install

On the other hand, I can just insert commands that 'byte-compile' and 'install' targets run into PKGBUILD (file used by package building tool of my system) but use of 'Makefile' to install all needed files is common practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment