Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add ac-yasnippet.el, remove source from auto-complete-config.el. #171

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

monsanto commented Sep 21, 2012

I'm making this a pull request so we can discuss a few issues relating organization (and in case anyone wants to do a code review).

  1. I think the best course of action is to have trivial sources (like this one) directly in the tree. Non-trivial sources (like emacs-auto-complete-clang, which requires building a C program) should be in a separate repo in this organization.

  2. @m2ym, I figure I'll work on porting the sources in parallel with 1.x/2.0 development. I think it will be easy to switch to the new interface. Do you have the interface finalized at this point, so I can just go ahead and port "ahead of schedule"?

  3. Should we have tests for sources?

Contributor

monsanto commented Sep 21, 2012

One other thing: a number of init functions in auto-complete-config.el add ac-source-yasnippet explicitly. I think the best course of action is for the user to use setq-default to add ac-source-yasnippet if they want it in all modes.

Owner

m2ym commented Sep 21, 2012

Maybe, we should create ac-yasnippet repo for special support. Yasnippet is always broken. I don't want AC to be broken as well.

@m2ym m2ym closed this Feb 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment