Abort autocomplete when less than ac-auto-start characters (to avoid fre... #83

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

...eze when huge number of candidates for single-character matches)

Abort autocomplete when less than ac-auto-start characters (to avoid …
…freeze when huge number of candidates for single-character matches)
Owner

m2ym commented Mar 21, 2012

Have you tried setting ac-candidate-limit? And if you don't byte-compile auto-complete.el, it gets much slower for use.

I haven't set ac-candidate-limit (unless it is set by default). As far as I know I byte compiled all the files (using the included makefile), but I've not messed around with Emacs lisp very much, so I may have missed something.

However, with the patch I made, I've had no further slowdown problems - it cancels the autocompleting as soon as I'm down to 1 character.

Member

tkf commented Aug 1, 2012

Does this patch treat the requires source attribute?
http://cx4a.org/software/auto-complete/manual.html#requires

I think this patch unconditionally abort auto-complete, ignoring requires attribute.

Owner

m2ym commented Sep 2, 2012

ac-auto-start can be t, so this patch could cause some error. But I think this practical workaround can be acceptable, though requires should be considered correctly.

@ghost ghost assigned m2ym Sep 2, 2012

Member

tkf commented Mar 23, 2013

I just tried to write code that considers the requires property. But I think it is impossible with the current architecture of AC: ac-prefix holds one prefix value. There could be different prefix values for different sources. If this PR is pulled, sources with custom prefix definition and requires property stop working. So, I suggest not to pull this PR for now and release 1.4. We can solve this after the code base was refactored for 2.0.

Relevant: #218

This was referenced Mar 23, 2013

@m2ym m2ym closed this Feb 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment