New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the current project owner and relations with Kite #308

Open
dessant opened this Issue May 13, 2017 · 53 comments

Comments

Projects
None yet
@dessant
Contributor

dessant commented May 13, 2017

The main developer of this project was @sadovnychyi until recently [1], he does not appear to be a Kite employee [2].

On December 1, 2016 @dhung09, a Kite employee, made his very first pull request [3] for this project, integrating Kite. @dhung09 also had push access and merged his own PR.

On January 25, 2017 @abe33, a Kite employee, made his first pull request [4] for this project, and merged it without any public discussion taking place.

Since then @sadovnychyi gradually stopped contributing [5] and all new commits were authored by @abe33, other Kite employees are also showing activity on issue threads.

Kite is not mentioned anywhere in the README.

Please share the nature and circumstances of the apparent maintainer transition taking place, and specify how does it relate to Kite and its employees.

[1] https://github.com/autocomplete-python/autocomplete-python/graphs/contributors
[2] https://kite.com/aboutus
[3] #250
[4] #276
[5] https://github.com/autocomplete-python/autocomplete-python/commits/master?author=sadovnychyi

@sadovnychyi

This comment has been minimized.

Show comment
Hide comment
@sadovnychyi

sadovnychyi May 13, 2017

Member
Member

sadovnychyi commented May 13, 2017

@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi May 17, 2017

Relevant issue: #299 #285.
Also atom-minimap/minimap#588 - injecting an opt-out kite promotion into the minimap plugin is in my opinion more than shady behaviour. 😞
I don't understand at all why the Kite devs don't fork into their own autcomplete-kite plugin autocomplete provider, and promote that? Especially as they plan to support more languages "soon", anyway.

bilderbuchi commented May 17, 2017

Relevant issue: #299 #285.
Also atom-minimap/minimap#588 - injecting an opt-out kite promotion into the minimap plugin is in my opinion more than shady behaviour. 😞
I don't understand at all why the Kite devs don't fork into their own autcomplete-kite plugin autocomplete provider, and promote that? Especially as they plan to support more languages "soon", anyway.

@sadovnychyi

This comment has been minimized.

Show comment
Hide comment
@sadovnychyi

sadovnychyi May 17, 2017

Member
Member

sadovnychyi commented May 17, 2017

@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi May 17, 2017

sorry for being unclear, it's opt-out in the minimap plugin, and kept that way by Kite devs even though users (all) complained.

bilderbuchi commented May 17, 2017

sorry for being unclear, it's opt-out in the minimap plugin, and kept that way by Kite devs even though users (all) complained.

@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi May 17, 2017

I can assure you that I'm going to keep supporting the Jedi part of this package, and it's not going to be replaced with Kite or something else.

I'm very relieved to hear this, and that you will stay watchful, btw.

bilderbuchi commented May 17, 2017

I can assure you that I'm going to keep supporting the Jedi part of this package, and it's not going to be replaced with Kite or something else.

I'm very relieved to hear this, and that you will stay watchful, btw.

@dessant

This comment has been minimized.

Show comment
Hide comment
@dessant

dessant May 17, 2017

Contributor

@sadovnychyi, thanks for following back. I'm not sure if you have researched this issue, but many of us feel the autocomplete-python package is being overtaken by the Kite team, and the popularity of this plugin is being used to promote their service.

It's also worth noting that there are no regular signs of these new maintainers being introduced to the project. Having push access before your first contribution is atypical, and it is not an isolated case of one developer.

I believe we could hear more about how this collaboration came to be, and how/where did those discussions happen.

Contributor

dessant commented May 17, 2017

@sadovnychyi, thanks for following back. I'm not sure if you have researched this issue, but many of us feel the autocomplete-python package is being overtaken by the Kite team, and the popularity of this plugin is being used to promote their service.

It's also worth noting that there are no regular signs of these new maintainers being introduced to the project. Having push access before your first contribution is atypical, and it is not an isolated case of one developer.

I believe we could hear more about how this collaboration came to be, and how/where did those discussions happen.

@sadovnychyi

This comment has been minimized.

Show comment
Hide comment
@sadovnychyi

sadovnychyi May 17, 2017

Member

@dessant, it's hard to deny that as a result they (Kite) did get a promotion out of this. It's not like we have a lot of autocomplete options available for python, so I did have some interest in Kite when it was announced. It would be awesome if Jedi (or another open source project) would add completions based on machine learning, but it didn't happen yet.

I'm sorry that they weren't properly introduced into the project (and as I said before some new bugs were created as well), but this is not a huge open source project with strict guidelines, so I considered it would be fine. (again, mistakes were made, let's learn from this and move on).

The discussion happened over the email and as I said it seemed like both parties (kite and autocomplete-python) could improve each other based on this collaboration.

There's other Atom packages (e.g. go-plus) which combines a set of features for the language, so it seems completely fine to provide multiple completion providers in this package, it's called autocomplete-python, not autocomplete-jedi or something.

This package grows, and I'm still new to this, but I'm doing my best to keep it alive.

Member

sadovnychyi commented May 17, 2017

@dessant, it's hard to deny that as a result they (Kite) did get a promotion out of this. It's not like we have a lot of autocomplete options available for python, so I did have some interest in Kite when it was announced. It would be awesome if Jedi (or another open source project) would add completions based on machine learning, but it didn't happen yet.

I'm sorry that they weren't properly introduced into the project (and as I said before some new bugs were created as well), but this is not a huge open source project with strict guidelines, so I considered it would be fine. (again, mistakes were made, let's learn from this and move on).

The discussion happened over the email and as I said it seemed like both parties (kite and autocomplete-python) could improve each other based on this collaboration.

There's other Atom packages (e.g. go-plus) which combines a set of features for the language, so it seems completely fine to provide multiple completion providers in this package, it's called autocomplete-python, not autocomplete-jedi or something.

This package grows, and I'm still new to this, but I'm doing my best to keep it alive.

@douglascamata

This comment has been minimized.

Show comment
Hide comment
@douglascamata

douglascamata Jul 18, 2017

So, one more package receiving pushes of @abe33 forcing Kite promotion. One more to uninstall. I like to keep my development environment 100% free software. 👋

I wonder... don't Kite have its own package for Atom? Why hijack all the good open and free choices in the ecosystem?

douglascamata commented Jul 18, 2017

So, one more package receiving pushes of @abe33 forcing Kite promotion. One more to uninstall. I like to keep my development environment 100% free software. 👋

I wonder... don't Kite have its own package for Atom? Why hijack all the good open and free choices in the ecosystem?

@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi Jul 18, 2017

In short: yes, they do; and an ill-conceived advertisement strategy (imo)

bilderbuchi commented Jul 18, 2017

In short: yes, they do; and an ill-conceived advertisement strategy (imo)

@dkerkow

This comment has been minimized.

Show comment
Hide comment
@dkerkow

dkerkow Jul 18, 2017

I am concerned about the way Kite devs are behaving in the atom ecosystem. I just read about the minimap incident by accident and am not comfortable with commercial services being injected into plugins like these. Why on earth is Kite enabled by default for this project? I can see your motivation for opening the plugin for other autocomplete engines, but Kite could live in a separate plugin as well while still be callable from autocomplete-python. I would strongly suggest to revert write access for Kite devs and give them the opportunity to hook in via Opt-IN. Everything else is harmful for the projects reputation.

dkerkow commented Jul 18, 2017

I am concerned about the way Kite devs are behaving in the atom ecosystem. I just read about the minimap incident by accident and am not comfortable with commercial services being injected into plugins like these. Why on earth is Kite enabled by default for this project? I can see your motivation for opening the plugin for other autocomplete engines, but Kite could live in a separate plugin as well while still be callable from autocomplete-python. I would strongly suggest to revert write access for Kite devs and give them the opportunity to hook in via Opt-IN. Everything else is harmful for the projects reputation.

@laurieskelly

This comment has been minimized.

Show comment
Hide comment
@laurieskelly

laurieskelly Jul 18, 2017

@dessant @sadovnychyi
Just for context this is the screen where you make your "opt-in" choice of Kite or Jedi (a.k.a. unnamed "lower accuracy, less complete" local engine) during install

image

laurieskelly commented Jul 18, 2017

@dessant @sadovnychyi
Just for context this is the screen where you make your "opt-in" choice of Kite or Jedi (a.k.a. unnamed "lower accuracy, less complete" local engine) during install

image

@dessant

This comment has been minimized.

Show comment
Hide comment
@dessant

dessant Jul 19, 2017

Contributor

@sadovnychyi, how do you feel about the screenshot @laurieskelly posted? Do you believe the presentation in that promt benefits this project and its users?

Contributor

dessant commented Jul 19, 2017

@sadovnychyi, how do you feel about the screenshot @laurieskelly posted? Do you believe the presentation in that promt benefits this project and its users?

@sadovnychyi

This comment has been minimized.

Show comment
Hide comment
@sadovnychyi

sadovnychyi Jul 19, 2017

Member

@dessant well it states everything it does, isn't? Except that it doesn't mention that the "local" engine is powered by Jedi. Anyway, if you believe something should be done differently I'm sure there's always a solution since it's open source.

Member

sadovnychyi commented Jul 19, 2017

@dessant well it states everything it does, isn't? Except that it doesn't mention that the "local" engine is powered by Jedi. Anyway, if you believe something should be done differently I'm sure there's always a solution since it's open source.

@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi Jul 19, 2017

Yeah, along with a number of UX dark patterns to make "sure" that inexperienced users make the "right" choice (frame-highlighted vs no-frame, bright green vs grey subdued button, font weight and brightness if I see correctly). They could maybe reinforce that effect by changing the text on the horizontal line to "or, if you must insist,...". :-/
I guess nobody would object to a neutral, balanced presentation of the two options.

bilderbuchi commented Jul 19, 2017

Yeah, along with a number of UX dark patterns to make "sure" that inexperienced users make the "right" choice (frame-highlighted vs no-frame, bright green vs grey subdued button, font weight and brightness if I see correctly). They could maybe reinforce that effect by changing the text on the horizontal line to "or, if you must insist,...". :-/
I guess nobody would object to a neutral, balanced presentation of the two options.

@adamsmith

This comment has been minimized.

Show comment
Hide comment
@adamsmith

adamsmith Jul 20, 2017

Collaborator

For added context, after the screenshot above, these are the following steps that the user must go through to get Kite:

screen shot 2017-07-19 at 5 14 44 pm

screen shot 2017-07-19 at 5 15 05 pm

(Small technicality: these screenshots say that Kite is installing but it's actually only downloading the installer binary to memory; the actual install doesn't happen unless the user goes through all three steps. It's also worth noting that if the user clicks "Add Later" no code is sent to the Kite servers for analysis until they whitelist a directory.)

Collaborator

adamsmith commented Jul 20, 2017

For added context, after the screenshot above, these are the following steps that the user must go through to get Kite:

screen shot 2017-07-19 at 5 14 44 pm

screen shot 2017-07-19 at 5 15 05 pm

(Small technicality: these screenshots say that Kite is installing but it's actually only downloading the installer binary to memory; the actual install doesn't happen unless the user goes through all three steps. It's also worth noting that if the user clicks "Add Later" no code is sent to the Kite servers for analysis until they whitelist a directory.)

@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi Jul 20, 2017

btw where is the code for that choice dialog? I searched for some of the strings displayed in the dialog, but couldn't find it using the github repo code search.

bilderbuchi commented Jul 20, 2017

btw where is the code for that choice dialog? I searched for some of the strings displayed in the dialog, but couldn't find it using the github repo code search.

@Arcanemagus

This comment has been minimized.

Show comment
Hide comment
@Arcanemagus

Arcanemagus commented Jul 20, 2017

@RubenSandwich

This comment has been minimized.

Show comment
Hide comment
@RubenSandwich

RubenSandwich Jul 24, 2017

The last version without any Kite code in it is 1.8.11. Unfortunately, this version does not seem to exist on the apm registry so you can't install it through the command line. If someone could repackage that version for easy installation I'm sure others would be grateful.

RubenSandwich commented Jul 24, 2017

The last version without any Kite code in it is 1.8.11. Unfortunately, this version does not seem to exist on the apm registry so you can't install it through the command line. If someone could repackage that version for easy installation I'm sure others would be grateful.

@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi Jul 24, 2017

hopefully @abe33 would agree to revert these changes like he did for atom-minimap, and probably pull out kite support into a separate plugin.
Otherwise someone else could look into identifying the Kite-related changes and propose a PR which reverts them.

bilderbuchi commented Jul 24, 2017

hopefully @abe33 would agree to revert these changes like he did for atom-minimap, and probably pull out kite support into a separate plugin.
Otherwise someone else could look into identifying the Kite-related changes and propose a PR which reverts them.

@dessant

This comment has been minimized.

Show comment
Hide comment
@dessant

dessant Jul 24, 2017

Contributor

@sadovnychyi, please tell us if you intend to revert the Kite itegration, or if we should fork the project instead.

The issue is on the front page of HN:
https://news.ycombinator.com/item?id=14836653

Contributor

dessant commented Jul 24, 2017

@sadovnychyi, please tell us if you intend to revert the Kite itegration, or if we should fork the project instead.

The issue is on the front page of HN:
https://news.ycombinator.com/item?id=14836653

@franciscop

This comment has been minimized.

Show comment
Hide comment
@franciscop

franciscop Jul 24, 2017

@sadovnychyi to be fair if negative language is allowed in the choice dialogue it should also highlight the downsides of Kite:

Uploads your files and data to internet (vulnerable, closed source, privacy disabled).

Otherwise it's just a dark pattern as many have pointed out, not just "the truth".

franciscop commented Jul 24, 2017

@sadovnychyi to be fair if negative language is allowed in the choice dialogue it should also highlight the downsides of Kite:

Uploads your files and data to internet (vulnerable, closed source, privacy disabled).

Otherwise it's just a dark pattern as many have pointed out, not just "the truth".

@DanielJoyce

This comment has been minimized.

Show comment
Hide comment
@DanielJoyce

DanielJoyce Jul 24, 2017

well the reviews for Kite in that article are pretty terrible from those who had used it. This doesn't look good. What marketing person thought this was a good idea?

DanielJoyce commented Jul 24, 2017

well the reviews for Kite in that article are pretty terrible from those who had used it. This doesn't look good. What marketing person thought this was a good idea?

@MrStonedOne

This comment has been minimized.

Show comment
Hide comment
@MrStonedOne

MrStonedOne Jul 24, 2017

I said this in the minimap thread but i'll repeat it here:

Do not spread, believe, or entertain any bullshit about forking being a form of "fragmenting the community" as a bad thing. The whole point of open source is that anybody is able to make a fork, and allow the community to decide. A fragmented community is good for open source, it reduces the impacts of bad actions like this. Another name for it would be distributed.

The entire reason this was even a big deal was because there is no where near enough competition, there is always the "one" tool to do something. That "one" plugin that provides a function, with the runner up (if it exist) having no where near the amount of users, features, or coders.

As a user base, we have stop collesasing around these tools and start spreading out more. As it is, these open source projects become single point of failures or otherwise big targets because everybody is obsessed with using the #1 project.

So never stigmatize forking as "fragmenting the community".

MrStonedOne commented Jul 24, 2017

I said this in the minimap thread but i'll repeat it here:

Do not spread, believe, or entertain any bullshit about forking being a form of "fragmenting the community" as a bad thing. The whole point of open source is that anybody is able to make a fork, and allow the community to decide. A fragmented community is good for open source, it reduces the impacts of bad actions like this. Another name for it would be distributed.

The entire reason this was even a big deal was because there is no where near enough competition, there is always the "one" tool to do something. That "one" plugin that provides a function, with the runner up (if it exist) having no where near the amount of users, features, or coders.

As a user base, we have stop collesasing around these tools and start spreading out more. As it is, these open source projects become single point of failures or otherwise big targets because everybody is obsessed with using the #1 project.

So never stigmatize forking as "fragmenting the community".

@dessant

This comment has been minimized.

Show comment
Hide comment
@dessant

dessant Jul 25, 2017

Contributor

A pull request has been submitted for removing Kite: #323.

Contributor

dessant commented Jul 25, 2017

A pull request has been submitted for removing Kite: #323.

@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi Jul 25, 2017

Do you know why the PR submitter closed their own PR shortly after opening?

bilderbuchi commented Jul 25, 2017

Do you know why the PR submitter closed their own PR shortly after opening?

@MrStonedOne

This comment has been minimized.

Show comment
Hide comment
@MrStonedOne

MrStonedOne Jul 25, 2017

Its no matter, the code commiter does not have to be the pr opener.

MrStonedOne commented Jul 25, 2017

Its no matter, the code commiter does not have to be the pr opener.

@MrStonedOne

This comment has been minimized.

Show comment
Hide comment
@MrStonedOne

MrStonedOne commented Jul 25, 2017

@faroit

This comment has been minimized.

Show comment
Hide comment
@faroit

faroit Jul 25, 2017

@MrStonedOne @brennv @dessant I would like a kiteless fork of this project, and I am sure this will be welcomed by the community as well. Concerning the name: maybe go for autocomplete-python-jedi?

faroit commented Jul 25, 2017

@MrStonedOne @brennv @dessant I would like a kiteless fork of this project, and I am sure this will be welcomed by the community as well. Concerning the name: maybe go for autocomplete-python-jedi?

@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi Jul 25, 2017

I am sure this will be welcomed by the community as well

I wouldn't be so sure about that, because it would mean that the bullies have won, have pushed the concerned users out into an obscure package, and can keep astroturfing the established name and the known plugin with the large userbase.

Imho it would be much preferable to get #324 merged and from this day on be more vigilant about contributions. That is also what happened over at the minimap plugin afaict. Kite can still take their stuff and make an autcomplete provider for kite, and get people to use it the old-fashioned way.

bilderbuchi commented Jul 25, 2017

I am sure this will be welcomed by the community as well

I wouldn't be so sure about that, because it would mean that the bullies have won, have pushed the concerned users out into an obscure package, and can keep astroturfing the established name and the known plugin with the large userbase.

Imho it would be much preferable to get #324 merged and from this day on be more vigilant about contributions. That is also what happened over at the minimap plugin afaict. Kite can still take their stuff and make an autcomplete provider for kite, and get people to use it the old-fashioned way.

@laurieskelly

This comment has been minimized.

Show comment
Hide comment
@laurieskelly

laurieskelly Jul 25, 2017

@bilderbuchi I'm not sure where I fall between your argument and @MrStonedOne. MSO's comment has the ideological solid ground, but I also feel like maybe a more direct action would be required to fix the harm this drift from sound principles has caused in this particular case.

That all being saiiiiidddd, I don't think that Kite-removing PRs will do much good unless @sadovnychyi has revoked push access for the Kite employees who would need to approve the PR. 🎶 They pretty much bought the means of production (or of auto-completion as it were), so comrades methinks the best way to re-seize them is to fork

laurieskelly commented Jul 25, 2017

@bilderbuchi I'm not sure where I fall between your argument and @MrStonedOne. MSO's comment has the ideological solid ground, but I also feel like maybe a more direct action would be required to fix the harm this drift from sound principles has caused in this particular case.

That all being saiiiiidddd, I don't think that Kite-removing PRs will do much good unless @sadovnychyi has revoked push access for the Kite employees who would need to approve the PR. 🎶 They pretty much bought the means of production (or of auto-completion as it were), so comrades methinks the best way to re-seize them is to fork

@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi Jul 25, 2017

Sure, but who will maintain the fork and ensure further development? I'm guessing @sadovnychyi won't be much inclined when everybody jumps ship from his fork, and it seems from the initial motivation for bringing @abe33 on board, other helpers will also be hard to find.
Therefore, in all probability you will get to enjoy your ideological high ground, but if nobody will be prepared to pick up the dirty work (like it is right now), you will just sit on a pile of rotting code, while kite still have control of the plugin that everybody uses right now.

bilderbuchi commented Jul 25, 2017

Sure, but who will maintain the fork and ensure further development? I'm guessing @sadovnychyi won't be much inclined when everybody jumps ship from his fork, and it seems from the initial motivation for bringing @abe33 on board, other helpers will also be hard to find.
Therefore, in all probability you will get to enjoy your ideological high ground, but if nobody will be prepared to pick up the dirty work (like it is right now), you will just sit on a pile of rotting code, while kite still have control of the plugin that everybody uses right now.

@brennv

This comment has been minimized.

Show comment
Hide comment
@brennv

brennv Jul 25, 2017

Contributor

@bilderbuchi @MrStonedOne @dessant I closed #323 after I realized @janneraiskila had already done some work in this direction here back in April: janneraiskila@9ea5de8 @faroit Some additional refactoring was required for the name change but the package is out. This whole situation is unfortunate, and, for me anyways, somewhat unfamiliar when Python is involved.

Contributor

brennv commented Jul 25, 2017

@bilderbuchi @MrStonedOne @dessant I closed #323 after I realized @janneraiskila had already done some work in this direction here back in April: janneraiskila@9ea5de8 @faroit Some additional refactoring was required for the name change but the package is out. This whole situation is unfortunate, and, for me anyways, somewhat unfamiliar when Python is involved.

@dessant

This comment has been minimized.

Show comment
Hide comment
@dessant

dessant Jul 25, 2017

Contributor

@brennv, thanks for forking the project!

Contributor

dessant commented Jul 25, 2017

@brennv, thanks for forking the project!

@dessant

This comment has been minimized.

Show comment
Hide comment
@dessant

This comment has been minimized.

Show comment
Hide comment
@dessant

dessant Jul 25, 2017

Contributor

@lee-dohm, what is involved in making autocomplete-python-jedi a featured package?

https://atom.io/packages/autocomplete-python-jedi
https://github.com/brennv/autocomplete-python-jedi

Contributor

dessant commented Jul 25, 2017

@lee-dohm, what is involved in making autocomplete-python-jedi a featured package?

https://atom.io/packages/autocomplete-python-jedi
https://github.com/brennv/autocomplete-python-jedi

@faroit

This comment has been minimized.

Show comment
Hide comment
@faroit

faroit Jul 25, 2017

@dessant

https://www.theregister.co.uk/2017/07/25/kite_flies_into_a_fork/

"Since this story was published, autocomplete-python has been forked."

🐦: 🐦 🐦

faroit commented Jul 25, 2017

@dessant

https://www.theregister.co.uk/2017/07/25/kite_flies_into_a_fork/

"Since this story was published, autocomplete-python has been forked."

🐦: 🐦 🐦

@dessant

This comment has been minimized.

Show comment
Hide comment
@dessant

dessant Jul 26, 2017

Contributor

As we considered our options, we had a novel idea: buy an open source plugin, reward the author for their work, and expose new users to Kite.

We reached out to the author of an Atom plugin called autocomplete-python. We told him about Kite, how we used machine learning to build a type inference engine that outperforms anything else out there, and we proposed forming a business relationship to work together.

https://kite.com/blog/responding-to-minimap-autocomplete-issues

The plugin being sold to Kite, or the financial nature of the collaboration, has not been disclosed by @sadovnychyi or the Kite team, not even when they were asked to do so in this thread. I think this is important to consider for everyone who decides to use this package.

Contributor

dessant commented Jul 26, 2017

As we considered our options, we had a novel idea: buy an open source plugin, reward the author for their work, and expose new users to Kite.

We reached out to the author of an Atom plugin called autocomplete-python. We told him about Kite, how we used machine learning to build a type inference engine that outperforms anything else out there, and we proposed forming a business relationship to work together.

https://kite.com/blog/responding-to-minimap-autocomplete-issues

The plugin being sold to Kite, or the financial nature of the collaboration, has not been disclosed by @sadovnychyi or the Kite team, not even when they were asked to do so in this thread. I think this is important to consider for everyone who decides to use this package.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 29, 2017

Deleting minimap and autocomplete-python - will avoid Kite like fire from now on. Shoving your spyware service without user consent should not be taken lightly.

ghost commented Jul 29, 2017

Deleting minimap and autocomplete-python - will avoid Kite like fire from now on. Shoving your spyware service without user consent should not be taken lightly.

@dessant

This comment has been minimized.

Show comment
Hide comment
@dessant

dessant Aug 1, 2017

Contributor

Kite telemetry code in Sublime package SideBarEnhancements.

https://news.ycombinator.com/item?id=14902630

Contributor

dessant commented Aug 1, 2017

Kite telemetry code in Sublime package SideBarEnhancements.

https://news.ycombinator.com/item?id=14902630

@Arcanemagus

This comment has been minimized.

Show comment
Hide comment
@Arcanemagus

Arcanemagus Aug 1, 2017

@JGH1000 All Kite code has been removed from minimap btw.

Arcanemagus commented Aug 1, 2017

@JGH1000 All Kite code has been removed from minimap btw.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 2, 2017

Thanks for the link @dessant, great read.

@Arcanemagus yes, I noticed. Though this seems to be a much bigger problem - as you can read in the SideBarEnhancements link, Kite gathered user data for almost a year before anyone noticed. Luckily someone noticed this in minimap, but how many other packages are affected?

We can't vet everything - @lee-dohm and other should look carefully at this. If not addressed, Atom/VSCode/Sublime will become a breading ground for spyware tactics. The only thing I can think of is sandboxing with permission system and banning offenders (like Kite) from submitting anything. Otherwise the only alternative would be to use only very popular, well reviewed packages (and hope 3rd parties look closely at the source code) or move to products which have most of the features build in (JetBrains software like PyCharm).

Sad news for anyone supporting open source software and platforms.

ghost commented Aug 2, 2017

Thanks for the link @dessant, great read.

@Arcanemagus yes, I noticed. Though this seems to be a much bigger problem - as you can read in the SideBarEnhancements link, Kite gathered user data for almost a year before anyone noticed. Luckily someone noticed this in minimap, but how many other packages are affected?

We can't vet everything - @lee-dohm and other should look carefully at this. If not addressed, Atom/VSCode/Sublime will become a breading ground for spyware tactics. The only thing I can think of is sandboxing with permission system and banning offenders (like Kite) from submitting anything. Otherwise the only alternative would be to use only very popular, well reviewed packages (and hope 3rd parties look closely at the source code) or move to products which have most of the features build in (JetBrains software like PyCharm).

Sad news for anyone supporting open source software and platforms.

@jpike88

This comment has been minimized.

Show comment
Hide comment
@jpike88

jpike88 Aug 2, 2017

I'm frankly disgusted by Kite's conduct here and elsewhere, and hope that you, @sadovnychyi are able to maintain a proper, open source, commercially neutral project. You do your reputation and the open source community a disservice by allowing this to happen. So please fix it.

But, if you sold yourself out, then make it clear to us. Stop beating around the bush and start being open to those who put their time and energy into helping your project become what it is now. Put proper Kite branding on it and make it obvious.

And to Kite, screw you guys. Seriously. Go make your own goddamn software instead of hijacking other people's creations.

jpike88 commented Aug 2, 2017

I'm frankly disgusted by Kite's conduct here and elsewhere, and hope that you, @sadovnychyi are able to maintain a proper, open source, commercially neutral project. You do your reputation and the open source community a disservice by allowing this to happen. So please fix it.

But, if you sold yourself out, then make it clear to us. Stop beating around the bush and start being open to those who put their time and energy into helping your project become what it is now. Put proper Kite branding on it and make it obvious.

And to Kite, screw you guys. Seriously. Go make your own goddamn software instead of hijacking other people's creations.

@sadovnychyi

This comment has been minimized.

Show comment
Hide comment
@sadovnychyi

sadovnychyi Aug 2, 2017

Member

I think those for whom it's really important should use a fork instead.

As I said before, the idea of this package being backed up by a company seemed like a win-win for everybody, because it's about adding another completion engine into autocomplete package. I heard about Kite before they contacted me and I was excited about what they were doing, applying ML for coding is fun, give me local models (even if it's ten of GB) and I'm sold. So yeah -- I accepted their offer to integrate Kite as another provider in autocomplete-python, and we verbally agreed that I would keep working on Jedi part of it (and that it's going to be up to a user to decide what to use), while they will ship their features in. And I'm sorry, but I cannot undo that. I think there's a lot of overreaction here because of what they have done with other packages, but I don't think that it's really that out-of-context in here, and at the time when I did review their code I didn't see any way for their application to send your code somewhere automatically without you knowing about it. You have to install that thing and give your information to it, including your email, willingly. They even have an issue that it's impossible to do so without registration.

With this merged it should look better, but people should probably demand the positioning of Kite/Jedi being randomized, or Jedi adjusted to the right for those on RTL systems, since it's still unfair. But that's up to community! I can fix bugs and answer on issues sometimes, but this thread and the whole story is getting really hard to follow. I didn't have any communication with Kite guys ~since I gained the push access to them, so you should probably send any demands related to Kite to them instead of me, I cannot just remove them.

Member

sadovnychyi commented Aug 2, 2017

I think those for whom it's really important should use a fork instead.

As I said before, the idea of this package being backed up by a company seemed like a win-win for everybody, because it's about adding another completion engine into autocomplete package. I heard about Kite before they contacted me and I was excited about what they were doing, applying ML for coding is fun, give me local models (even if it's ten of GB) and I'm sold. So yeah -- I accepted their offer to integrate Kite as another provider in autocomplete-python, and we verbally agreed that I would keep working on Jedi part of it (and that it's going to be up to a user to decide what to use), while they will ship their features in. And I'm sorry, but I cannot undo that. I think there's a lot of overreaction here because of what they have done with other packages, but I don't think that it's really that out-of-context in here, and at the time when I did review their code I didn't see any way for their application to send your code somewhere automatically without you knowing about it. You have to install that thing and give your information to it, including your email, willingly. They even have an issue that it's impossible to do so without registration.

With this merged it should look better, but people should probably demand the positioning of Kite/Jedi being randomized, or Jedi adjusted to the right for those on RTL systems, since it's still unfair. But that's up to community! I can fix bugs and answer on issues sometimes, but this thread and the whole story is getting really hard to follow. I didn't have any communication with Kite guys ~since I gained the push access to them, so you should probably send any demands related to Kite to them instead of me, I cannot just remove them.

@dessant

This comment has been minimized.

Show comment
Hide comment
@dessant

dessant Aug 2, 2017

Contributor

As I said before, the idea of this package being backed up by a company seemed like a win-win for everybody

@sadovnychyi, you did not say autocomplete-python is sponsored or owned by Kite. This was your initial explanation for integrating Kite:

For me Kite seemed to be like an interesting optional integration for python completions, so I did gave them the access since I don't have much time implementing another completions provider by myself.

And that was the narrative until the issue received widespread attention, despite repeated calls everywhere to clarify why are Kite employees acting like they own this project, and why isn't there any resistance from your part.

We have trusted you as the owner of a FOSS project, and by refusing to disclose that the package was sold, we were prevented from looking into who the new owners are, to decide if we should also trust them, and whether it is still safe to continue using the project.

The README and package description still does not mention who the new owners of autocomplete-python are.

Contributor

dessant commented Aug 2, 2017

As I said before, the idea of this package being backed up by a company seemed like a win-win for everybody

@sadovnychyi, you did not say autocomplete-python is sponsored or owned by Kite. This was your initial explanation for integrating Kite:

For me Kite seemed to be like an interesting optional integration for python completions, so I did gave them the access since I don't have much time implementing another completions provider by myself.

And that was the narrative until the issue received widespread attention, despite repeated calls everywhere to clarify why are Kite employees acting like they own this project, and why isn't there any resistance from your part.

We have trusted you as the owner of a FOSS project, and by refusing to disclose that the package was sold, we were prevented from looking into who the new owners are, to decide if we should also trust them, and whether it is still safe to continue using the project.

The README and package description still does not mention who the new owners of autocomplete-python are.

@MrStonedOne

This comment has been minimized.

Show comment
Hide comment
@MrStonedOne

MrStonedOne Aug 2, 2017

As I said before, the idea of this package being backed up by a company seemed like a win-win for everybody, because it's about adding another completion engine into autocomplete package.

Ya, and now you see how horribly competition works when you give certain entities the ability to dictate the terms, as well as the power to just flat out control how they and their competition are represented. It breeds bad faith and dark UI patterns.

This very quickly, in the course of a few commits, went from competing prediction engines to the engine that has a financial motivation abusing their control over this repo to trick more users into signing up.

It doesn't matter if they are offering a free service, if you have a scaling percentage of paid conversions, more free users == more paid users, and giving them control over what is suppose to be a neutral ground is a conflict of interest.

Kit employees commiting to this repo can not act in the best interest of this plugin or its users because they also have a conflicting interest in promoting the company's products, regardless of how it effects the plugin or its users.

And it doesn't matter how much those employees convince themselves they are neutral or that they are acting in the best interest of this plugin and its users, the whole point of worrying over CoI's is preventing even a subconscious bias.

So, at this juncture, there are two options:

  • Either this becomes the Official™ Kite™ auto complete plugin.

OR

  • Kite™ and their employees are removed from having push access over this repo to keep it neutral.

Those are it, those are the two choices. There is no neutral third option, there is no middle ground.

You can not have a neutral market of competition when one side has both financial motivators and control over the market (this plugin).

MrStonedOne commented Aug 2, 2017

As I said before, the idea of this package being backed up by a company seemed like a win-win for everybody, because it's about adding another completion engine into autocomplete package.

Ya, and now you see how horribly competition works when you give certain entities the ability to dictate the terms, as well as the power to just flat out control how they and their competition are represented. It breeds bad faith and dark UI patterns.

This very quickly, in the course of a few commits, went from competing prediction engines to the engine that has a financial motivation abusing their control over this repo to trick more users into signing up.

It doesn't matter if they are offering a free service, if you have a scaling percentage of paid conversions, more free users == more paid users, and giving them control over what is suppose to be a neutral ground is a conflict of interest.

Kit employees commiting to this repo can not act in the best interest of this plugin or its users because they also have a conflicting interest in promoting the company's products, regardless of how it effects the plugin or its users.

And it doesn't matter how much those employees convince themselves they are neutral or that they are acting in the best interest of this plugin and its users, the whole point of worrying over CoI's is preventing even a subconscious bias.

So, at this juncture, there are two options:

  • Either this becomes the Official™ Kite™ auto complete plugin.

OR

  • Kite™ and their employees are removed from having push access over this repo to keep it neutral.

Those are it, those are the two choices. There is no neutral third option, there is no middle ground.

You can not have a neutral market of competition when one side has both financial motivators and control over the market (this plugin).

@jpike88

This comment has been minimized.

Show comment
Hide comment
@jpike88

jpike88 Aug 3, 2017

As I said before, the idea of this package being backed up by a company seemed like a win-win for everybody

No, it's not a win-win. It's a win-lose. The losers are those who worked with an open source project, and expect it to continue respect the principles of being open source. And that includes transparency.

So yeah -- I accepted their offer to integrate Kite as another provider in autocomplete-python
you should probably send any demands related to Kite to them instead of me, I cannot just remove them.

So it's not just an offer to integrate something, they basically bought you. You have lost control of your repo, and it is at least in part the property of Kite.

So brand it as a Kite product (or a co-owned Kite and @sadovnychyi product), and make it clear to developers that this open source project is not what it used to be, and any future improvements (or even this repo being made private in future) is done at the whims of Kite.

Simple stuff. We all deserve your honesty, and if Kite has that level of control over you where you can't even do the right thing, then what the hell kind of agreement did you enter into!

jpike88 commented Aug 3, 2017

As I said before, the idea of this package being backed up by a company seemed like a win-win for everybody

No, it's not a win-win. It's a win-lose. The losers are those who worked with an open source project, and expect it to continue respect the principles of being open source. And that includes transparency.

So yeah -- I accepted their offer to integrate Kite as another provider in autocomplete-python
you should probably send any demands related to Kite to them instead of me, I cannot just remove them.

So it's not just an offer to integrate something, they basically bought you. You have lost control of your repo, and it is at least in part the property of Kite.

So brand it as a Kite product (or a co-owned Kite and @sadovnychyi product), and make it clear to developers that this open source project is not what it used to be, and any future improvements (or even this repo being made private in future) is done at the whims of Kite.

Simple stuff. We all deserve your honesty, and if Kite has that level of control over you where you can't even do the right thing, then what the hell kind of agreement did you enter into!

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 3, 2017

After reading @sadovnychyi comments it is clear that further discussion on those issues should be done with Atom devs and the community. Probably worth opening a ticket to find a solution to this very big challenge to open source model.

@sadovnychyi - I agree with others that you should add much more information regarding any compensation you might have received from Kite and clarify to user that the Kite company co-owns the plugin and that activating it means the code will be send to them (which might not be secure).

Also claiming that Kite is better than Jedi should be backed up by 3rd party reviews - novice users might be swayed by the description not realizing the underlying issues.

This is no longer an open-source, transparent product as we have no idea what this company will do with the code, especially given their very immoral tactics. People should think twice about using any of their services.

For anyone that cares, we should all move to autocomplete-python-jedi which is kindly supported by @brennv. He seems to be making a lot of changes to it as well. Spread the word.

ghost commented Aug 3, 2017

After reading @sadovnychyi comments it is clear that further discussion on those issues should be done with Atom devs and the community. Probably worth opening a ticket to find a solution to this very big challenge to open source model.

@sadovnychyi - I agree with others that you should add much more information regarding any compensation you might have received from Kite and clarify to user that the Kite company co-owns the plugin and that activating it means the code will be send to them (which might not be secure).

Also claiming that Kite is better than Jedi should be backed up by 3rd party reviews - novice users might be swayed by the description not realizing the underlying issues.

This is no longer an open-source, transparent product as we have no idea what this company will do with the code, especially given their very immoral tactics. People should think twice about using any of their services.

For anyone that cares, we should all move to autocomplete-python-jedi which is kindly supported by @brennv. He seems to be making a lot of changes to it as well. Spread the word.

@faroit

This comment has been minimized.

Show comment
Hide comment
@faroit

faroit Aug 4, 2017

For anyone that cares, we should all move to autocomplete-python-jedi which is kindly supported by @brennv. He seems to be making a lot of changes to it as well. Spread the word.

https://twitter.com/pycoders/status/893473358922358784

faroit commented Aug 4, 2017

For anyone that cares, we should all move to autocomplete-python-jedi which is kindly supported by @brennv. He seems to be making a lot of changes to it as well. Spread the word.

https://twitter.com/pycoders/status/893473358922358784

@ghisvail

This comment has been minimized.

Show comment
Hide comment
@ghisvail

ghisvail Aug 18, 2017

As a result of this thread, I have now replaced this plugin with autocomplete-python-jedi and will be actively recommending others to follow this move.

ghisvail commented Aug 18, 2017

As a result of this thread, I have now replaced this plugin with autocomplete-python-jedi and will be actively recommending others to follow this move.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 14, 2017

Update to anyone interested - in the next release, Atom will introduce the IDE functionality. It has autocomplete, linting, refactoring, formatting and everything you could want. Nteract member @lgeiger already create an early access package called ide-python that wraps the python language server developed by Palantir (@gatesn and others). Clearly the way to go for python-related development (faster and much more feature packed) and having a single package reduces a chance of rouge code. Can't wait for a stable release, exciting times!

https://github.com/lgeiger/ide-python
https://github.com/palantir/python-language-server

ghost commented Sep 14, 2017

Update to anyone interested - in the next release, Atom will introduce the IDE functionality. It has autocomplete, linting, refactoring, formatting and everything you could want. Nteract member @lgeiger already create an early access package called ide-python that wraps the python language server developed by Palantir (@gatesn and others). Clearly the way to go for python-related development (faster and much more feature packed) and having a single package reduces a chance of rouge code. Can't wait for a stable release, exciting times!

https://github.com/lgeiger/ide-python
https://github.com/palantir/python-language-server

@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi Sep 14, 2017

I'm not yet sure how I feel about Facebook's bsd+patents license that is used in atom-ide-ui, and the resource usage of all that extra stuff.

bilderbuchi commented Sep 14, 2017

I'm not yet sure how I feel about Facebook's bsd+patents license that is used in atom-ide-ui, and the resource usage of all that extra stuff.

@brennv

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

This comment has been minimized.

Show comment
Hide comment
@bilderbuchi

bilderbuchi Sep 27, 2017

Well, that's for react and a good development, but atom-ide-ui still has the patents file as of now: https://github.com/facebook-atom/atom-ide-ui?files=1

bilderbuchi commented Sep 27, 2017

Well, that's for react and a good development, but atom-ide-ui still has the patents file as of now: https://github.com/facebook-atom/atom-ide-ui?files=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment