Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error In Rutorrent #9

Closed
Pingblue opened this issue Jul 14, 2014 · 8 comments

Comments

Projects
None yet
5 participants
@Pingblue
Copy link

commented Jul 14, 2014

After updating rutorrent to the latest SVN on two of my servers today I now have this error in rutorrent.

[14.07.2014 20:20:15] AutodlIrssiTab._getNewLines: Exception info: name = TypeError; message = $.browser is undefined; fileName = https://myserver.com/rutorrent/plugins/autodl-irssi/AutodlFilesDownloader.js; lineNumber = 28;

@Pingblue

This comment has been minimized.

Copy link
Author

commented Jul 14, 2014

Can be fixed by replacing
if ($.browser.msie)
with
$.browser={ msie: ( navigator.appName == 'Microsoft Internet Explorer') ? true : false }

@thebigmunch

This comment has been minimized.

Copy link
Member

commented Jul 14, 2014

I'm not going to fix anything for SVN version of ruTorrent. When they release the next stable version, just post again in this issue if it's still an issue (probably will be as I'd guess they finally updated their included jQuery version).

@d0cx

This comment has been minimized.

Copy link

commented Jul 15, 2014

it will probably continue to be an issue. Pingblue's fix seems to work just fine. to clarify, the replacement should be only

$.browser.msie

for

$.browser={ msie: ( navigator.appName == 'Microsoft Internet Explorer') ? true : false }

so the line would actually be

if ($.browser={ msie: ( navigator.appName == 'Microsoft Internet Explorer') ? true : false })

@astupidmoose

This comment has been minimized.

Copy link

commented Jul 20, 2014

Rutorrent did update to the latest Jquery as per their changelog. I can confirm the above fixes work.

Is this fix also compatible with the stable version of rutorrent? If so, it might be worth patching just to save the headache for everyone.

@thebigmunch

This comment has been minimized.

Copy link
Member

commented Jul 20, 2014

Compatible? You mean relevent. And that would seem like something you would be able to test, but as I haven't heard anything except from people using ruTorrent from the SVN tree, there was really no point in posting anything. autodl-rutorrent will not be updated until it affects the latest stable release of ruTorrent, period. If you want to use a piece of software in unstable form, this kinda thing comes along with it.

@astupidmoose

This comment has been minimized.

Copy link

commented Jul 21, 2014

I do not see any issue with making the change to avoid further issues if its backwards compatible. I would be willing to complete a fresh install and make the change for testing purposes if that was required.

Rutorrent suggests users to use SVN, even on the forums they are always saying "Install from SVN". I am not sure they really use "Stable Releases" as they are constantly editing and making changes. More than likely this will need to be fixed in the future stable release, so why not change it now and not worry about it? It will save many people time and effort of having to look up this fix.

@thebigmunch

This comment has been minimized.

Copy link
Member

commented Jul 21, 2014

They do make stable releases; check out their download section. The people behind ruTorrent are known for many bad practices, just add suggesting the SVN version to that list (unless you're misunderstanding them suggesting someone update to fix a specific issue that isn't in a release yet). All software is in a state of flux... in the development tree/branch. You're free to use the unstable development version of software, but you will then have to deal with any issues that arise from doing so like being incompatible with other pieces of software; this is the case for all software and always has been. Even if I made this change now, it'd only be in the development branch, so people would still need to come and look up this fix (which they almost surely have to do even if it were in master to figure out they could fix it by updating). So there's not much of a point to be made there.

Please don't continue to push this. I made myself clear in the beginning. And I've had to repeat myself multiple times now, which I loathe. I'll make the change when the stable release comes. Someone post here if I don't get to it beforehand.

@ne0ark

This comment has been minimized.

Copy link

commented Aug 15, 2014

Thanks for the fix.

Paladin-z pushed a commit to Paladin-z/seedbox-from-scratch that referenced this issue Dec 2, 2015

Paladin-z
Create AutodlFilesDownloader.js
Version in autodl-community has error in line 28 (autodl-community/autodl-rutorrent#9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.