Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PackageIcon in .csproj #1057

Closed
tillig opened this issue Dec 4, 2019 · 2 comments · Fixed by #1058
Closed

Add PackageIcon in .csproj #1057

tillig opened this issue Dec 4, 2019 · 2 comments · Fixed by #1058

Comments

@tillig
Copy link
Contributor

@tillig tillig commented Dec 4, 2019

Recent packaging operations are starting to issue a warning that the 'PackageIconUrl'/'iconUrl' element is deprecated and we should switch to 'PackageIcon'/'icon'.

More info here.

Based on that doc...

You should specify both PackageIcon and PackageIconUrl to maintain backward compatibility with clients and sources that do not yet support PackageIcon. Visual Studio will support PackageIcon for packages coming from a folder-based source in a future release.

Seems easy enough. I'm not sure we should use an images folder for the icon but maybe it could live in the root of the repo or the build folder or something.

@tillig

This comment has been minimized.

Copy link
Contributor Author

@tillig tillig commented Dec 4, 2019

I gather this is a thing that we'll have to do for all the projects, so... yeah. And switching from license URL to PackageLicenseExpression.

@alistairjevans

This comment has been minimized.

Copy link
Member

@alistairjevans alistairjevans commented Dec 15, 2019

I'll PR the change for core now; when we make the multiple changes to the integrations for referencing 5.0 we can update the packageicon and packagelicense info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.