Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1030 - Allow ParameterFilterAttribute to check if parameter can be resolved #1053

Merged
merged 5 commits into from Nov 26, 2019

Conversation

@RaymondHuy
Copy link
Member

RaymondHuy commented Nov 26, 2019

Add new method to ParameterFilterAttribute to check if parameter can be resolved.

RaymondHuy added 4 commits Nov 21, 2019
Merge
@tillig tillig changed the title Fix Issue#1030 Fix #1030 - Allow ParameterFilterAttribute to check if parameter can be resolved Nov 26, 2019
Copy link
Contributor

tillig left a comment

This is much better. I think having the "can resolve" concept in the attributes like it is elsewhere makes sense. I think the logic in the MetadataFilterAttribute may be able to be simplified a bit by removing some redundant bits, but otherwise looks good.

@tillig
tillig approved these changes Nov 26, 2019
Copy link
Contributor

tillig left a comment

Nice work. Thanks!

@tillig tillig merged commit 53a10c1 into autofac:develop Nov 26, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@RaymondHuy RaymondHuy deleted the RaymondHuy:Issue1030 branch Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.