Ignore compiler generated classes on autoregistration #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dealing with deferred IEnumerables (using yield return/break) the compiler generates a helper class to handle the deferred execution. Autoregistration discovers this class and registers it as a provider for IEnumerable<T> thus preventing the user from being able to resolve all implementations of T.
| @@ -436,5 +436,15 @@ public void ScanningKeyedRegistrationsFilterByAssignabilityBeforeMappingKey() | |||
| })); | |||
| Assert.True(c.IsRegisteredWithKey<IAService>(k)); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void DefferedEnumerableHelperClassDoesNotGetRegistered() | |||
There was a problem hiding this comment.
Minor typo - two 'f's in the test name "Defferred" => "Deferred"
|
Nice catch! I think there's one minor typo to fix up and we can pull it. Thanks! |
|
Fixed the typo. Glad that I could help! |
tillig
added a commit
that referenced
this pull request
Feb 29, 2016
Ignore compiler generated classes on assembly scanning / auto-registration.
|
Pulled. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When dealing with deferred IEnumerables (using yield return/break) the compiler generates a helper class to handle the deferred execution. Autoregistration discovers this class and registers it as a provider for IEnumerable thus preventing the user from being able to resolve all implementations of T.