Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and cleaned up methods for log and local submissions #163

Merged
merged 7 commits into from
Jan 23, 2015

Conversation

icanb
Copy link
Member

@icanb icanb commented Jan 22, 2015

No description provided.

@icanb
Copy link
Member Author

icanb commented Jan 22, 2015

This should not be merged yet, but I wanted to push it to get your comments.

@icanb icanb changed the title revised unofficial method with the right return statements Fixed and cleaned up methods for log and local submissions Jan 22, 2015
@icanb
Copy link
Member Author

icanb commented Jan 22, 2015

This is up for review now

@dlbucci
Copy link
Member

dlbucci commented Jan 22, 2015

How well has this been tested? We seem to still be getting error reports.

@icanb
Copy link
Member Author

icanb commented Jan 23, 2015

I think those errors were from while I was developing.

@dlbucci
Copy link
Member

dlbucci commented Jan 23, 2015

The ones mentioned at the end of #126?

@icanb
Copy link
Member Author

icanb commented Jan 23, 2015

Gonna work on those soon.

@dlbucci
Copy link
Member

dlbucci commented Jan 23, 2015

Alright, well I don't think we're any worse off with this in then, so I'll merge.

dlbucci pushed a commit that referenced this pull request Jan 23, 2015
Fixed and cleaned up methods for log and local submissions
@dlbucci dlbucci merged commit 0a5c3ca into master Jan 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants