Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/NumericPredicate
This cop does not support auto-correct, is generally noisy in our codebases,
and not that helpful. Reasoning for the default is dubious:
"The default is the predicate. The benefit of that is you'll avoid silent
errors when accidentally comparing to nil, and will instead get a runtime
error. The downside is people might not immediately know whether 0 is
considered positive or not."
I'm not sure about that reasoning because
nil > 0
is not a silent error.Also, the conditional style is more performance (on a micro scale)